all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: Lukas Sichert <l.sichert@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager] ui: fabrics: skip unsupported ip6 interface properties on submit
Date: Wed, 3 Jun 2026 16:22:11 +0200	[thread overview]
Message-ID: <f0e4f884-20a7-4196-b1a3-e6b523a905f9@proxmox.com> (raw)
In-Reply-To: <20260603124917.56707-1-l.sichert@proxmox.com>

On 2026-06-03 14:49, Lukas Sichert wrote:
> The interface grid keeps the node interface data in the record even if
> BGP disables the IPv6 column via 'hasIpv6Support=false'. As getValue()
> serializes the full record data, BGP interfaces could still submit an
> 'ip6' property. This results in the error 'format error
> interfaces[0].ip6: property is not defined in schema'.
> 
> Skip 'ip6' during serialization when IPv6 support is disabled for the
> panel.
> 

the same happens if a IPv4 address is configured for the interface
(in `/etc/network/interfaces`)

we should probably add `hasIpv4Support` to the InterfacePanel, like we
already have it for FabricEdit. then we can also handle the ipv6 col the
same way we do the ipv4 col.. and drop the `initComponent`-thingy in
`bgp/InterfacePanel.js`

> Signed-off-by: Lukas Sichert <l.sichert@proxmox.com>
> ---
>  www/manager6/sdn/fabrics/InterfacePanel.js | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/www/manager6/sdn/fabrics/InterfacePanel.js b/www/manager6/sdn/fabrics/InterfacePanel.js
> index f07e7859..74781267 100644
> --- a/www/manager6/sdn/fabrics/InterfacePanel.js
> +++ b/www/manager6/sdn/fabrics/InterfacePanel.js
> @@ -174,7 +174,10 @@ Ext.define('PVE.sdn.Fabric.InterfacePanel', {
>                      continue;
>                  }
>  
> -                if (['type', 'isDisabled'].includes(key)) {
> +                if (
> +                    ['type', 'isDisabled'].includes(key) ||
> +                    (key === 'ip6' && !me.hasIpv6Support)
> +                ) {
>                      continue;
>                  }
>  





  reply	other threads:[~2026-06-03 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 12:49 [PATCH manager] ui: fabrics: skip unsupported ip6 interface properties on submit Lukas Sichert
2026-06-03 14:22 ` Hannes Laimer [this message]
2026-06-05  8:25 ` superseded: " Lukas Sichert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0e4f884-20a7-4196-b1a3-e6b523a905f9@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=l.sichert@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal