From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 208F71FF142 for ; Mon, 02 Mar 2026 13:59:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 89F8130CB5; Mon, 2 Mar 2026 14:00:25 +0100 (CET) Message-ID: Date: Mon, 2 Mar 2026 14:00:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH ha-manager] resources: Expand max_restart option To: pve-devel@lists.proxmox.com References: <20260302122831.319795-1-m.sandoval@proxmox.com> Content-Language: en-US From: Hannes Duerr In-Reply-To: <20260302122831.319795-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772456397130 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BIDO2PU5HBDT4GQVAYLRE64TKVTI6SD5 X-Message-ID-Hash: BIDO2PU5HBDT4GQVAYLRE64TKVTI6SD5 X-MailFrom: h.duerr@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/2/26 1:28 PM, Maximiliano Sandoval wrote: > When read next to `max_relocate` it is not clear which happens first > after a service fails to start. > > Signed-off-by: Maximiliano Sandoval > --- > > When writting I initially had "When reached, the service will be attempted to be > relocated" since it was clear it had to be on a "node" but as per HA rules not > all of them might be eligible or some of them might already have reached the > max_restart limit. > > src/PVE/HA/Resources.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm > index 68d9d16..66dd7b4 100644 > --- a/src/PVE/HA/Resources.pm > +++ b/src/PVE/HA/Resources.pm > @@ -73,7 +73,8 @@ EODESC > }, > max_restart => { > description => "Maximal number of tries to restart the service on" > - . " a node after its start failed.", > + . " a node after its start failed. When reached, the service will be attempted to" > + . " be relocated on an eligible node.", The phrasing is a bit too complicated, would the following make sense? `When reached, the HA manager will try to move the service to another eligible node.` > type => 'integer', > optional => 1, > default => 1,