From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 060A71FF17A for ; Tue, 28 Oct 2025 14:30:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7FC831B834; Tue, 28 Oct 2025 14:30:46 +0100 (CET) Date: Tue, 28 Oct 2025 14:30:41 +0100 From: Wolfgang Bumiller To: Hannes Laimer Message-ID: References: <20251024144250.145205-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251024144250.145205-1-h.laimer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761658229253 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] applied-series: [PATCH proxmox{, -datacenter-manager} v2 0/4] generate Vec's for string-lists X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" applied the series with some followups (see reply to patch 1/3), thanks On Fri, Oct 24, 2025 at 04:42:46PM +0200, Hannes Laimer wrote: > PVE does accept actual arrays[1] as input to fields with a `-list` format. > This updates the generator so it produces a Vec if it is a parameter, > not for return values. > > I did not find endpoint that directly share the same format for > parameters and return value. Update endpoint also include a > `delete`-field and those were the only ones that had really similar > input and output formats. So deduplication in the generate _should_ not be > a problem here. > > This required some small changes to pdm. Context for those is in the > commit itself. > > v2, thanks @Wolfgang: > - fix/improve perl code > - add `is_option_vec`-flag, like we do for `is_string_list` > > > [1] pve-common 69d9edcc ("section config: implement array support") > > > proxmox: > > Hannes Laimer (3): > pve-api-types: schema2rust: generate arrays for types with format > `-list` > pve-api-types: add regex for both storage- and bridge-pair > pve-api-types: regenerate > > pve-api-types/generate.pl | 11 +- > pve-api-types/generator-lib/Schema2Rust.pm | 41 ++- > pve-api-types/src/generated/code.rs | 2 +- > pve-api-types/src/generated/types.rs | 335 +++++++++++---------- > pve-api-types/src/types/verifiers.rs | 10 - > 5 files changed, 220 insertions(+), 179 deletions(-) > > > proxmox-datacenter-manager: > > Hannes Laimer (1): > server: use types indead of string for migration parameters > > server/src/api/pve/lxc.rs | 133 ++++++++---------------------------- > server/src/api/pve/qemu.rs | 135 ++++++++----------------------------- > 2 files changed, 56 insertions(+), 212 deletions(-) > > > Summary over all repositories: > 7 files changed, 276 insertions(+), 391 deletions(-) > > -- > Generated by git-murpp 0.8.1 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel