From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 32BB262D2F for <pbs-devel@lists.proxmox.com>; Fri, 18 Sep 2020 12:10:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2ECF215060 for <pbs-devel@lists.proxmox.com>; Fri, 18 Sep 2020 12:10:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A912915053 for <pbs-devel@lists.proxmox.com>; Fri, 18 Sep 2020 12:10:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 62F0345433 for <pbs-devel@lists.proxmox.com>; Fri, 18 Sep 2020 12:10:40 +0200 (CEST) To: pbs-devel@lists.proxmox.com References: <20200918090052.79979-1-h.laimer@proxmox.com> From: Dominik Csapak <d.csapak@proxmox.com> Message-ID: <ef26b2e3-f644-971f-26c7-7da42a66a0ea@proxmox.com> Date: Fri, 18 Sep 2020 12:10:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200918090052.79979-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.518 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, proxmox-backup-proxy.rs, datastore.rs] Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 0/6] add scheduled verification of datastore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 18 Sep 2020 10:10:41 -0000 like we talked off-list verification schedules are wanted, but we probably want to have them more like we have sync-jobs independent of datastores (so we can have multiple verification schedules per datastore, which will be important once we have parameters such as 'verify only unverified snapshots') also please use the 'Job' helper for keeping track of the state since that is cheaper than searching for the last time in the task list On 9/18/20 11:00 AM, Hannes Laimer wrote: > Adds support for scheduling the verification of datastores the same way > GC or Prune is scheduled. > > v2: - add patch to make verify-schedule deletable > > Hannes Laimer (6): > api2: add VERIFY_SCHEDULE_SCHEMA > add verify_schedule field to DataStoreConfig > api2: add optional verify-schdule field to create/update datastore > endpoint > api2: make verify_schedule deletable > ui: add verify-schedule field to edit datastore form > add verification scheduling to proxmox-backup-proxy > > src/api2/config/datastore.rs | 10 +++ > src/api2/types/mod.rs | 5 ++ > src/bin/proxmox-backup-proxy.rs | 104 +++++++++++++++++++++++++++++++- > src/config/datastore.rs | 9 ++ > www/config/DataStoreConfig.js | 5 +- > www/window/DataStoreEdit.js | 9 +++ > 6 files changed, 139 insertions(+), 3 deletions(-) >