From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C4DE61FF16F for ; Tue, 5 Aug 2025 07:57:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B4BDC3E1D4; Tue, 5 Aug 2025 07:59:02 +0200 (CEST) Message-ID: Date: Tue, 5 Aug 2025 07:58:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20250804065331.45272-1-c.ebner@proxmox.com> <3e5e341f-3bf7-4103-89b2-b63db6a91a75@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <3e5e341f-3bf7-4103-89b2-b63db6a91a75@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754373490879 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v3 0/4] s3: extend config by provider-quirks and client options by feature list X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 8/4/25 10:17 PM, Thomas Lamprecht wrote: > Am 04.08.25 um 08:54 schrieb Christian Ebner: >> These patches extend the s3 client configuration by the additional >> `provider-quirks` enum, allowing to switch to provider specific implementation >> details. The provider specific quirks are then mapped to a list of features and >> limitations, added to the s3 client options. >> >> As first use-case, the `If-None-Match` header is not set during put object >> requests to Backblaze B2 or Infomaniak object stores, as these fail with an >> error with status code 501, therefore chunk uploads will fail. > > Why not expose the actual quirk (features) directly? Even if we'd like to > have specific providers a user can select, that part could be a frontend > only feature, and tbh. for starters I'd even skip that, maybe documenting > provider to quirks in the PBS wiki might be a good option for now. > > I'm just a bit wary of locking our backend in to those provider, as there > are quite a few of S3 provider, and not all might be here with us forever, > and having dozens of providers all mapping just to one or two actual > quirks each seems a bit overkill to me. > Sorry, I should have taken a closer check earlier to provider quicker > feedback. The intention was to have it easy for the user to select the required features, therefore the mapping from provider to features. But you are absolutely right that this might introduce maintenance burden in the long run, as the list of providers is then backed into the config. So I do agree, will move this over to only expose the features in the config and the single NoIfNoneMatchHeader in the UI for now (and maybe call them quirks, after all?) _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel