From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 899291FF17A
	for <inbox@lore.proxmox.com>; Fri, 18 Jul 2025 12:21:16 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 687AA1A1D0;
	Fri, 18 Jul 2025 12:22:24 +0200 (CEST)
Message-ID: <eee17de3-e1e0-41ac-acde-88c857f3c94a@proxmox.com>
Date: Fri, 18 Jul 2025 12:21:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
References: <20250718101223.68650-1-f.ebner@proxmox.com>
Content-Language: en-US
In-Reply-To: <20250718101223.68650-1-f.ebner@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1752834107893
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.027 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] superseded: [PATCH storage 1/2] lvm plugin: properly
 handle qcow2 format when querying volume size info
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Sorry, for the noise. I sent a v2 with better meta info:

https://lore.proxmox.com/pve-devel/20250718102023.70591-1-f.ebner@proxmox.com/T/#u

Am 18.07.25 um 12:12 PM schrieb Fiona Ebner:
> Fixes: eda88c9 ("lvmplugin: add qcow2 snapshot")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/Storage/LVMPlugin.pm | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
> index 7044c4f..6d57097 100644
> --- a/src/PVE/Storage/LVMPlugin.pm
> +++ b/src/PVE/Storage/LVMPlugin.pm
> @@ -930,8 +930,12 @@ sub volume_resize {
>  
>  sub volume_size_info {
>      my ($class, $scfg, $storeid, $volname, $timeout) = @_;
> +
> +    my ($format) = ($class->parse_volname($volname))[6];
>      my $path = $class->filesystem_path($scfg, $volname);
>  
> +    return PVE::Storage::Plugin::file_size_info($path, $timeout, $format) if $format eq 'qcow2';
> +
>      my $cmd = [
>          '/sbin/lvs',
>          '--separator',



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel