From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id EE0301FF0B0 for ; Tue, 27 Oct 2026 11:14:51 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 78F7C217D7; Tue, 27 Oct 2026 11:13:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=genua.de; s=202307; t=1793095958; bh=KdJJpTcJKhum/s/Owbx3T1XEIpnHxepKD2WQaOSSwcc=; h=Date:From:To:Subject:References:In-Reply-To:From; b=JDSn6zo/g3X7nTWjSfQqbuuwD7TTryDgGE2BEIGMRWln8DBsY8zH0mQ9OXNDzZm4X Ppoyog6hOWCWB75TQMzFu4IV5vrgCuZIx+/4hJcQjcf85PbhwfTiaSJ/3631CIdT2M eKhy/mkzkK39VCxo2JeMvNmdFVyoZJfiZdyJra2ePk4KeKHgx7WRwoip/1tueodjFp W0j4zY9a74IOUXTClUvwhvEwzQbu6lbwGnVw2qgS/vq4y1IYrrqiczmHHI+3nNx72J wLzCbfzkbz3dB9xmMDYPtbykXOSkw37V3sY9shUdDOCXTfsxYCcfq/N0BFsQerJSw3 ubmh3ok2wY19w== Date: Tue, 27 Oct 2026 11:12:36 +0100 From: Christian Ludwig To: Subject: [PATCH pve-manager v3 17/19] ui: migrate: refuse migration with a local custom firmware image Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [192.168.217.185] X-ClientProxiedBy: kch1-mta09.win.genua.de (10.208.16.109) To kch1-mta07.win.genua.de (10.208.16.107) Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record UNPARSEABLE_RELAY 0.001 Informational: message has unparseable relay lines Message-ID-Hash: 54AU3R43JA77KLBCZOFSGCWOYAEPSPB7 X-Message-ID-Hash: 54AU3R43JA77KLBCZOFSGCWOYAEPSPB7 X-MailFrom: christian_ludwig@genua.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A custom firmware image is not owned by the VM and never copied to the target node, so the backend refuses the migration unless the image is on a shared storage. Show this as an error in the preconditions, rather than offering to migrate it like a local disk. Signed-off-by: Christian Ludwig --- www/manager6/window/Migrate.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js index 8cac54ea..89026d73 100644 --- a/www/manager6/window/Migrate.js +++ b/www/manager6/window/Migrate.js @@ -364,7 +364,16 @@ Ext.define('PVE.window.Migrate', { if (migrateStats.local_disks.length) { migrateStats.local_disks.forEach(function (disk) { - if (disk.cdrom && disk.cdrom === 1) { + if (disk.is_firmware) { + migration.possible = false; + migration.preconditions.push({ + text: Ext.String.format( + gettext('Cannot migrate VM with local custom firmware image: {0}'), + disk.volid, + ), + severity: 'error', + }); + } else if (disk.cdrom && disk.cdrom === 1) { if (!disk.volid.includes('vm-' + vm.get('vmid') + '-cloudinit')) { migration.possible = false; migration.preconditions.push({ -- 2.34.1