From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <a.lauterer@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9504B6C916 for <pve-devel@lists.proxmox.com>; Mon, 1 Feb 2021 11:53:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85FC5236F2 for <pve-devel@lists.proxmox.com>; Mon, 1 Feb 2021 11:53:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 16ABE236E5 for <pve-devel@lists.proxmox.com>; Mon, 1 Feb 2021 11:53:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CD592456E0 for <pve-devel@lists.proxmox.com>; Mon, 1 Feb 2021 11:53:24 +0100 (CET) To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20210201100612.28426-1-a.lauterer@proxmox.com> <805140b8-4f37-8645-1bba-5d6cfbcd382a@proxmox.com> From: Aaron Lauterer <a.lauterer@proxmox.com> Message-ID: <ec33d2d2-cb81-2077-894d-e90b46eb7678@proxmox.com> Date: Mon, 1 Feb 2021 11:53:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <805140b8-4f37-8645-1bba-5d6cfbcd382a@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs] qm: fix hookscript example X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 01 Feb 2021 10:53:25 -0000 On 2/1/21 11:47 AM, Thomas Lamprecht wrote: > > but this is a style fix only, or? As a single minus always works for options > in CLIHandler based executables (we have no short-opts there). yes it is basically a style fix. It works with one dash. What does not work with one dash though (tested quickly) is the auto completion of the parameter. > > On 01.02.21 11:06, Aaron Lauterer wrote: >> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com> >> --- >> qm.adoc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qm.adoc b/qm.adoc >> index 333b2e6..e0cce2b 100644 >> --- a/qm.adoc >> +++ b/qm.adoc >> @@ -1333,7 +1333,7 @@ Hookscripts >> >> You can add a hook script to VMs with the config property `hookscript`. >> >> - qm set 100 -hookscript local:snippets/hookscript.pl >> + qm set 100 --hookscript local:snippets/hookscript.pl >> >> It will be called during various phases of the guests lifetime. >> For an example and documentation see the example script under >> >