From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 58B641FF0B2 for ; Thu, 20 Aug 2026 13:20:25 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F3E052156C; Thu, 20 Aug 2026 13:20:24 +0200 (CEST) Message-ID: Date: Thu, 20 Aug 2026 13:20:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH datacenter-manager v2 7/9] ui: pve: show ha maintenance mode for nodes To: Lukas Wagner , pdm-devel@lists.proxmox.com References: <20260818133000.3793412-1-d.csapak@proxmox.com> <20260818133000.3793412-8-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787224796936 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.687 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AS6T3NCGPCJKU5D63WOW344BHYI5PIKE X-Message-ID-Hash: AS6T3NCGPCJKU5D63WOW344BHYI5PIKE X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/20/26 1:07 PM, Lukas Wagner wrote: > On Tue Aug 18, 2026 at 3:25 PM CEST, Dominik Csapak wrote: >> By rendering a small `Badge` after the nodename in the pve tree and the >> resource tree, when the node is in ha maintenance mode. >> >> I opted for showing the ha state here differently than in PVE, because >> seeing the online/offline state separately from the hastate can make >> sense (so there is no ambiguity if the node is online or offline). >> >> To do this we have to add the hastate to the `PveNodeResource` and wire >> that through from the /cluster/resources call. >> >> We also have to update the pwt-assets submodule to get the necessary CSS >> classes for the badge. >> >> This partially fixes #7371. >> >> Signed-off-by: Dominik Csapak >> --- >> lib/pdm-api-types/src/resource.rs | 3 +++ >> server/src/api/resources.rs | 1 + >> ui/pwt-assets | 2 +- >> ui/src/pve/tree.rs | 11 +++++++++-- >> ui/src/renderer.rs | 14 +++++++++++++- >> ui/src/widget/resource_tree.rs | 3 ++- >> 6 files changed, 29 insertions(+), 5 deletions(-) >> >> diff --git a/lib/pdm-api-types/src/resource.rs b/lib/pdm-api-types/src/resource.rs >> index c433a284..288d8543 100644 >> --- a/lib/pdm-api-types/src/resource.rs >> +++ b/lib/pdm-api-types/src/resource.rs >> @@ -490,6 +490,9 @@ pub struct PveNodeResource { >> pub status: String, >> /// Subscription level >> pub level: String, >> + /// HA State >> + #[serde(default)] >> + pub hastate: String, > > I wonder, could we use a proper type here? E.g. something like > > enum HaState { > Maintenance, > ..., > Unknown > } sure, I'd like that too. I just adapted to the code around this^^ (e.g. the level and status field are similar strings) > > I'd also avoid carrying over these 'word amalgamations' and rather call > it at least 'ha_state' (serialized to 'ha-state'), but not a biggie for > me. > >> } > sure, i guess i was too fixated on keeping the fields the same as the pve ones