From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A257469094 for <pbs-devel@lists.proxmox.com>; Thu, 12 Nov 2020 10:18:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 996BFC75F for <pbs-devel@lists.proxmox.com>; Thu, 12 Nov 2020 10:18:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 38F9CC76B for <pbs-devel@lists.proxmox.com>; Thu, 12 Nov 2020 10:18:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F1F9441EF1 for <pbs-devel@lists.proxmox.com>; Thu, 12 Nov 2020 10:18:03 +0100 (CET) To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Stefan Reiter <s.reiter@proxmox.com> References: <36cbccc4-340b-933b-63d7-921bc332a25b@proxmox.com> <20201112091254.29059-1-s.reiter@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <eb5fa872-c15d-b57f-4e05-6a9fd2a60539@proxmox.com> Date: Thu, 12 Nov 2020 10:18:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201112091254.29059-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.097 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-manager.rs, apt.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] apt: use typed response for get_versions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 12 Nov 2020 09:18:04 -0000 On 12.11.20 10:12, Stefan Reiter wrote: > ...and cleanup get_versions for manager CLI. > > Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> > --- > > No need to return an untyped Value, especially if we want to further work with > it, so how about this for a cleanup? > > src/api2/node/apt.rs | 4 ++-- > src/bin/proxmox-backup-manager.rs | 10 ++-------- > 2 files changed, 4 insertions(+), 10 deletions(-) > > much nicer, and the obvious solution; I'd guess it was a bit to late for me yesterday ^^ applied, thanks!