From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3AAB360ABD for <pve-devel@lists.proxmox.com>; Thu, 13 Jan 2022 15:45:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 23B541FD56 for <pve-devel@lists.proxmox.com>; Thu, 13 Jan 2022 15:45:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C141D1FD48 for <pve-devel@lists.proxmox.com>; Thu, 13 Jan 2022 15:45:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8D27746B2E for <pve-devel@lists.proxmox.com>; Thu, 13 Jan 2022 15:45:14 +0100 (CET) Message-ID: <eb347e55-2168-c146-8100-a622ceb835f4@proxmox.com> Date: Thu, 13 Jan 2022 15:45:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20211201085514.1648428-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20211201085514.1648428-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lib.rs, proxmox.com, calendarevent.pm] Subject: [pve-devel] applied-series: [PATCH proxmox-perl-rs/common] use calendar-events from rust X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 13 Jan 2022 14:45:48 -0000 On 01.12.21 09:55, Dominik Csapak wrote: > this series replaces the perl calendar event implementation with the > one in rust, using proxmox-perl-rs > > the perl interface to 'PVE::CalendarEvent' is the same, but we could > use PVE::RS::CalendarEvent directly downstream (guest-common/manager) > but since we need the api type anyway i left that out for now > > with this, we now get all features from the rust implementation > in perl now, most notably the date part of events which makes it > possible to have e.g. backups less that once per week (e.g. on the > first of the month) > > this depends of course on my series to add 'UTC' to the events[0] > > 0: https://lists.proxmox.com/pipermail/pbs-devel/2021-December/004413.html > > proxmox-perl-rs: > > Dominik Csapak (1): > pve-rs: add PVE::RS::CalendarEvent > > pve-rs/Makefile | 1 + > pve-rs/src/calendar_event.rs | 20 ++++++++++++++++++++ > pve-rs/src/lib.rs | 1 + > 3 files changed, 22 insertions(+) > create mode 100644 pve-rs/src/calendar_event.rs > > pve-common: > > Dominik Csapak (1): > CalendarEvent: use rust implementation > > src/PVE/CalendarEvent.pm | 251 +----------------------------------- > test/calendar_event_test.pl | 42 +++--- > 2 files changed, 23 insertions(+), 270 deletions(-) > Applied with a followup to actually add `proxmox-time` as dependency in Cargo.toml to avoid the following compile error: Compiling pve-rs v0.5.0 (/root/sources/pve/proxmox-perl-rs/build/pve-rs) error[E0433]: failed to resolve: use of undeclared crate or module `proxmox_time` --> src/calendar_event.rs:9:26 | 9 | struct CalendarEvent(proxmox_time::CalendarEvent); | ^^^^^^^^^^^^ use of undeclared crate or module `proxmox_time`