From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id E1A1C73050
for <pve-devel@lists.proxmox.com>; Wed, 14 Apr 2021 15:54:49 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D7C5AF898
for <pve-devel@lists.proxmox.com>; Wed, 14 Apr 2021 15:54:49 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 3B8B4F889
for <pve-devel@lists.proxmox.com>; Wed, 14 Apr 2021 15:54:48 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F217E45AA5
for <pve-devel@lists.proxmox.com>; Wed, 14 Apr 2021 15:54:47 +0200 (CEST)
Message-ID: <ea463529-ea49-3dcf-49e4-2c705532b1c0@proxmox.com>
Date: Wed, 14 Apr 2021 15:54:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101
Thunderbird/88.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
References: <20210412142838.1332059-1-o.bektas@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20210412142838.1332059-1-o.bektas@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.042 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: Re: [pve-devel] [PATCH installer] highlight focused button with
dark orange
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 14 Apr 2021 13:54:49 -0000
On 12.04.21 16:28, Oguz Bektas wrote:
> idea was from community forum [0]
>
> arbitrary css can be used to style the installer, for now just add the
> highlight feature.
Not completely arbitrary, but yeah, most common stuff is
actually supported.
Anyway, I'd rather avoid pulling in such (under the hood) complex features,
and their actual issue would be rather solved with the planned terminal based
user interface (TUI).
Further, this may not be to friendly for people with color-sight impairments,
the default GTK theme is normally already designed with accessibility in mind,
changing styling may break assumptions baked in there.
Also, as Stoiko mentioned, the button class is used in more places than just
the obvious ones, so more subtle breakage/weirdness can happen.
Focused buttons are already highlighted, and the Alt+<underlined-key> helper
is available too for keyboard only installations, as documented in:
https://pve.proxmox.com/pve-docs/chapter-pve-installation.html#installation_installer
So no, I do not want to include such styling patches.
>
> [0]:
> https://forum.proxmox.com/threads/proxmox-installation-eye-catching-color.87440
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> proxinstall | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/proxinstall b/proxinstall
> index 03f6ec7..e79f0c6 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -25,6 +25,13 @@ use POSIX ":sys_wait_h";
>
> use ProxmoxInstallerSetup;
>
> +my $css_provider = Gtk3::CssProvider->new();
> +my $display = Gtk3::Gdk::Display::get_default;
> +my $screen = Gtk3::Gdk::Display::get_default_screen($display);
> +Gtk3::StyleContext::add_provider_for_screen($screen, $css_provider, 600);
> +my $prox_theme = "button:focus {\nbackground-color: #000000;\ncolor: #FF4500;\n}";
> +$css_provider->load_from_data($prox_theme);
> +
> my $setup = ProxmoxInstallerSetup::setup();
>
> my $opt_testmode;
>