From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DEDA11FF179 for ; Wed, 10 Dec 2025 14:30:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DBC521CBB4; Wed, 10 Dec 2025 14:31:35 +0100 (CET) Message-ID: Date: Wed, 10 Dec 2025 14:31:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pve-devel@lists.proxmox.com References: <20251210125724.121834-1-f.ebner@proxmox.com> <20251210132833.135013-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20251210132833.135013-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765373456486 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v3 qemu-server 3/3] migrate: remove left-over dbus-vmstate instance when migrating without conntrack state X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 10.12.25 um 2:29 PM schrieb Fiona Ebner: > As reported in the enterprise support, if something went wrong when > removing the dbus-vmstate object earlier, a following migrating using Sorry, this should be 'not using' here. > '--with-conntrack-state' will lead to a crash. > > Try to remove any leftover when migrating without the conntrack state. > > Signed-off-by: Fiona Ebner > --- > > Reported by Friedrich just after I sent the v3. Technically > orthogonal, and should get much less likely after patches 1+2 here, > but still good for future-proofing. > > src/PVE/QemuMigrate.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm > index 8fa84080..b3ddc34e 100644 > --- a/src/PVE/QemuMigrate.pm > +++ b/src/PVE/QemuMigrate.pm > @@ -254,6 +254,12 @@ sub prepare { > 'conntrack state migration not supported or disabled, ' > . 'active connections might get dropped', > ); > + > + # In case some leftover instance is running, stop it. The target QEMU instance won't > + # have the 'dbus-vmstate' object, so the source must not have it either. > + if (defined(PVE::QemuServer::DBusVMState::qemu_del_dbus_vmstate($vmid, quiet => 1))) { > + $self->log('warn', "stopped left-over dbus-vmstate helper for VM $vmid"); > + } > } > } > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel