From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0E6401FF183 for ; Wed, 30 Jul 2025 17:42:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF9B913BF0; Wed, 30 Jul 2025 17:43:34 +0200 (CEST) Message-ID: Date: Wed, 30 Jul 2025 17:43:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Shannon Sterz References: <20250730103705.98313-2-s.sterz@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250730103705.98313-2-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753890170107 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-storage 1/1] fix #6587: parse snapshot names beginning from the first underscore X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 30.07.25 um 12:37 PM schrieb Shannon Sterz: > Since regular expressions are typically greedy the old regex here > matched as many underscores as it could (`\S` matches anything that is > not a whitespace, so also `_`). This lead to an issue where snapshots > that contained an underscore in their name would be truncated to only > contain the part of the name after the last underscore. > > Use `[^\s_]` to match everything that is not a whitespace and not the > underscore character. > Problem is that right now, disk names may contain an underscore as well, i.e. pvesm alloc sharedlvm 100 vm-100-disk_with_underscore.qcow2 1M --format qcow2 which in particular means from a volume name alone like snap_vm-100-disk_with_underscore_here_s_some_more.qcow2 it is impossible to know how the disk is called and how the volume is. We either need to change the naming schema for snapshot and align it with what we do for the dir plugins or restrict the volume names for qcow2 on LVM (i.e. disallow _ as part of the volume name). _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel