From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 06C511FF13F for ; Thu, 18 Jun 2026 09:25:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 60C33CA34; Thu, 18 Jun 2026 09:25:42 +0200 (CEST) Message-ID: Date: Thu, 18 Jun 2026 09:25:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH qemu-server v2] fix #7705: blockdev: detach backing chain on disk move/hot-unplug To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260617121330.347174-1-a.bied-charreton@proxmox.com> Content-Language: en-US From: Jakob Klocker In-Reply-To: <20260617121330.347174-1-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781767448345 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.873 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: QQW75GNDAAFDV3FZI3IOMN7Z767UKEA3 X-Message-ID-Hash: QQW75GNDAAFDV3FZI3IOMN7Z767UKEA3 X-MailFrom: j.klocker@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I've tested the reproducer [0] both with and without the patch applied. Without the patch, lvremove failed because the source LV was still in use. I confirmed that the corresponding block node remained attached by checking QEMU's info block output. With the patch applied, lvremove completed successfully and I could no longer reproduce the issue. Consider this: Tested-by: Jakob Klocker [0] https://bugzilla.proxmox.com/show_bug.cgi?id=7705#c0 On 6/17/26 2:13 PM, Arthur Bied-Charreton wrote: > When snapshots-as-volume-chains is enabled, moving or hot-unplugging a > disk that holds snapshots does not detach the snapshot volumes. > [...]