From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 9CF87B363D
for <pbs-devel@lists.proxmox.com>; Wed, 29 Nov 2023 09:02:44 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 80CE21941
for <pbs-devel@lists.proxmox.com>; Wed, 29 Nov 2023 09:02:14 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Wed, 29 Nov 2023 09:02:13 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 44D9842261
for <pbs-devel@lists.proxmox.com>; Wed, 29 Nov 2023 09:02:13 +0100 (CET)
Message-ID: <e75f1e38-2a2f-46d8-9351-f3ee0bf486af@proxmox.com>
Date: Wed, 29 Nov 2023 09:02:12 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Hannes Laimer <h.laimer@proxmox.com>
Reply-To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
References: <20231128160415.81314-1-f.ebner@proxmox.com>
<c3d8d5e5-95a8-4f47-bf03-139543758a7c@proxmox.com>
<8809f49c-102a-49c2-b883-5634dc86f0b0@proxmox.com>
In-Reply-To: <8809f49c-102a-49c2-b883-5634dc86f0b0@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.078 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pbs-devel] [RFC proxmox-backup] ui: sync job edit: fix showing
value for target store upon edit of local sync job
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 29 Nov 2023 08:02:44 -0000
Am 29.11.23 um 08:42 schrieb Fiona Ebner:
> Am 29.11.23 um 07:54 schrieb Hannes Laimer:
>> On 11/28/23 17:04, Fiona Ebner wrote:
>>> when editing a local sync job, the field would be empty because of
>>> this and not be set to the previously configured remote-store.
>>>
>> do you mean when opening the edit window of a local sync job, or when
>> switching between local/remote? If the former, it's a bug, but I wasn't
>> able to reproduce it. If the later, it won't be possible to keep it when
>> switching, the store field is the same field for local and remote, as in
>> the job config.
>>
>
> The former with proxmox-backup-server=3.0.5-1. Happens with both Firefox
> and Chromium for me.
As discussed off-list with Hannes, there already is a fix for this in
current master: fbee4799 ("ui: fix local sync job edit") and I
completely missed that this was the reason it worked rather than my
change when testing. So my change should be reverted, sorry about that!