From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 3E6E71FF0E5 for ; Wed, 15 Jul 2026 13:57:53 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 93EB921408; Wed, 15 Jul 2026 13:57:52 +0200 (CEST) Message-ID: Date: Wed, 15 Jul 2026 13:57:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-manager 1/1] fabrics: wireguard: node edit: use network selector To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20260617135814.427399-1-s.hanreich@proxmox.com> <48309705-068f-449c-af24-cb2984985797@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <48309705-068f-449c-af24-cb2984985797@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.233 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: R2WSDYPIMSLNVAGG56RRE4LZX2DWLYOU X-Message-ID-Hash: R2WSDYPIMSLNVAGG56RRE4LZX2DWLYOU X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 7/15/26 1:50 PM, Dominik Csapak wrote: > one additional thing i just noticed inline > > On 6/17/26 3:57 PM, Stefan Hanreich wrote: >> For internal nodes, turn the endpoint form field into a network >> selector that allows users to select IP addresses from a dropdown. >> This makes the intention of the field clearer and also saves users >> some typing since they can just select any configured IP on the node >> without having to re-type it. >> >> The defaultFocus property is set for the node edit window, to avoid >> the network selector getting autofocused which leads to an ugly, >> mispositioned combogrid getting rendered automatically when the edit >> window gets rendered initially. Focus on the form can still be gained >> by pressing Tab an additional time. >> >> Suggested-by: Dominik Csapak >> Signed-off-by: Stefan Hanreich >> --- >>   .../sdn/fabrics/wireguard/NodeEdit.js         | 38 ++++++++++++++++++- >>   1 file changed, 36 insertions(+), 2 deletions(-) >> >> diff --git a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js b/www/ >> manager6/sdn/fabrics/wireguard/NodeEdit.js >> index fe4639ade..f0d513162 100644 >> --- a/www/manager6/sdn/fabrics/wireguard/NodeEdit.js >> +++ b/www/manager6/sdn/fabrics/wireguard/NodeEdit.js >> @@ -27,6 +27,8 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { >>           }, >>       }, >>   +    defaultFocus: 'no', >> + >>       additionalItems: [ >>           { >>               xtype: 'proxmoxtextfield', >> @@ -56,12 +58,37 @@ Ext.define('PVE.sdn.Fabric.WireGuard.Node.Edit', { >>               allowBlank: false, >>           }, >>           { >> -            xtype: 'proxmoxtextfield', >> +            // endpoint field for internal nodes >> +            xtype: 'proxmoxNetworkSelector', >> +            reference: 'networkSelector', >>               fieldLabel: gettext('Endpoint'), >>               emptyText: gettext('Host that peers connect to'), >>               labelWidth: 120, >>               name: 'endpoint', >> -            allowBlank: false, >> +            type: 'any_bridge', >> +            valueField: 'address', >> +            displayField: 'address', >> +            autoSelect: false, >> +            notFoundIsValid: true, >> +            editable: true, >> +            bind: { >> +                allowBlank: '{current.isPveNode}', >> +                hidden: '{!current.isPveNode}', >> +                disabled: '{!current.isPveNode}', >> +            }, >> +        }, >> +        { >> +            // endpoint field for external nodes >> +            xtype: 'proxmoxtextfield', >> +            fieldLabel: gettext('Endpoint'), >> +            emptyText: gettext('Host that peers connect to qqq'), > > that gettext has a stray 'qqq' Good catch - I'll resend a v2 with your previous comments addressed as well!