From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 06A131FF142 for ; Tue, 21 Apr 2026 13:35:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9A401CF47; Tue, 21 Apr 2026 13:35:02 +0200 (CEST) Message-ID: Date: Tue, 21 Apr 2026 13:34:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox{,-backup} v2 0/3] fixes #7465: add gc-on-unmount flag To: Hannes Laimer , pbs-devel@lists.proxmox.com References: <20260420074257.9492-1-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260420074257.9492-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1776771183724 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SXJWUM2DVNBR3M7HNOZK6FC6SRNGK5V6 X-Message-ID-Hash: SXJWUM2DVNBR3M7HNOZK6FC6SRNGK5V6 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/20/26 9:41 AM, Hannes Laimer wrote: > So GC can run before unmount, without this its somewhat complicated to > run gc on a datastore that is configured to auto unmount after jobs > finish. > > v2, thanks @Chris!: > - include proxmox patch > - don't lock config for just reading > - improve comments/commit msg > Thanks for addressing the comments from v1: Reviewed-by: Christian Ebner Tested-by: Christian Ebner