From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5BC7D1FF0B3 for ; Wed, 11 Nov 2026 16:41:14 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D1B41216AF; Wed, 11 Nov 2026 16:41:02 +0100 (CET) Message-ID: Date: Wed, 11 Nov 2026 16:40:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pve-manager v2 3/4] ui: backup: add error behavior and retry options To: Jakob Klocker , pve-devel@lists.proxmox.com References: <20261111093407.109872-1-j.klocker@proxmox.com> <20261111093407.109872-4-j.klocker@proxmox.com> Content-Language: en-US From: Jonas Theisen In-Reply-To: <20261111093407.109872-4-j.klocker@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794411655107 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.092 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SY6OBAEAOF24LHI5MPO42DBQAOVRLLKD X-Message-ID-Hash: SY6OBAEAOF24LHI5MPO42DBQAOVRLLKD X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/11/26 10:35, Jakob Klocker wrote: > Expose the `error-behavior` and `max-retries` vzdump parameters in the > scheduled datacenter backup and in the manual backup window. > > When creating a new backup job or starting a manual backup, the UI > defaults to `retry` with a maximum of 5 retries. > > The manual backup window only offers `retry` and `ignore`, since it > backs up a single guest, where `retry` and `retry-immediately` behave > the same. The width of the scheduled backup job window is increased > from 720 to 750 pixels so the new fields fit without cutting off their > labels. > > Signed-off-by: Jakob Klocker > --- > www/manager6/dc/Backup.js | 2 +- > www/manager6/panel/BackupAdvancedOptions.js | 52 +++++++++++++++++++++ > www/manager6/window/Backup.js | 45 +++++++++++++++++- > 3 files changed, 97 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js > index d3db9d9c..b640fa1a 100644 > --- a/www/manager6/dc/Backup.js > +++ b/www/manager6/dc/Backup.js > @@ -7,7 +7,7 @@ Ext.define('PVE.dc.BackupEdit', { > defaultFocus: undefined, > > subject: gettext('Backup Job'), > - width: 720, > + width: 750, > bodyPadding: 0, > > url: '/api2/extjs/cluster/backup', > diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js > index fe8cc3bf..b06011fe 100644 > --- a/www/manager6/panel/BackupAdvancedOptions.js > +++ b/www/manager6/panel/BackupAdvancedOptions.js > @@ -24,6 +24,11 @@ Ext.define('PVE.panel.BackupAdvancedOptions', { > me.lookup('fleecingStorage').setDisabled(!value); > }, > > + errorBehaviorChange: function (field, value) { > + let me = this; > + me.lookup('maxRetriesField').setDisabled(value === 'ignore'); > + }, > + > control: { > 'proxmoxcheckbox[reference=fleecingEnabled]': { > change: 'toggleFleecing', > @@ -117,6 +122,53 @@ Ext.define('PVE.panel.BackupAdvancedOptions', { > }, > > items: [ > + { > + xtype: 'pveTwoColumnContainer', > + startColumn: { > + xtype: 'proxmoxKVComboBox', > + fieldLabel: gettext('Error Behavior'), > + name: 'error-behavior', > + value: 'retry', The default "retry" also causes existing jobs to be silently switched over to that after an unrelated edit, which is not ideal. > diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js > index 0caada65..5552620b 100644 > --- a/www/manager6/window/Backup.js > +++ b/www/manager6/window/Backup.js > @@ -55,6 +55,34 @@ Ext.define('PVE.window.Backup', { > }, > }); > > + let maxRetriesField = Ext.create({ > + xtype: 'proxmoxintegerfield', > + fieldLabel: gettext('Max Retries'), > + name: 'max-retries', > + minValue: 1, > + maxValue: 10, > + value: 5, > + allowBlank: true, > + emptyText: '5', > + }); > + > + let errorBehaviorSelector = Ext.create({ > + xtype: 'proxmoxKVComboBox', > + fieldLabel: gettext('Error Behavior'), > + name: 'error-behavior', > + value: 'retry', > + deleteEmpty: false, > + comboItems: [ > + ['retry', gettext('Retry')], > + ['ignore', gettext('Ignore')], > + ], > + listeners: { > + change: function (field, value) { > + maxRetriesField.setDisabled(value === 'ignore'); > + }, > + }, > + }); > + > let pbsChangeDetectionModeSelector = Ext.create({ > xtype: 'proxmoxKVComboBox', > flex: 1, > @@ -250,7 +278,14 @@ Ext.define('PVE.window.Backup', { > bodyPadding: 10, > border: false, > column1: [storagesel, modeSelector, protectedCheckbox, pbsChangeDetection], > - column2: [compressionSelector, notificationModeSelector, mailtoField, removeCheckbox], > + column2: [ > + compressionSelector, > + notificationModeSelector, > + mailtoField, > + removeCheckbox, > + errorBehaviorSelector, > + maxRetriesField, > + ], > > columnB: [ > { > xtype: 'textareafield', > @@ -342,6 +377,14 @@ Ext.define('PVE.window.Backup', { > ); > } > > + if (values['error-behavior']) { > + params['error-behavior'] = values['error-behavior']; > + } > + > + if (values['max-retries'] !== undefined && values['max-retries'] !== '') { > + params['max-retries'] = values['max-retries']; > + } > + > Proxmox.Utils.API2Request({ > url: '/nodes/' + me.nodename + '/vzdump', > params: params, The manual backup window does not honor configured defaults for the two new parameters from /etc/vzdump.conf. So even if an admin was to set a different value there the GUI values would overwrite them.