From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D7BAD6AAE5 for <pve-devel@lists.proxmox.com>; Thu, 17 Mar 2022 09:20:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF7622FC1B for <pve-devel@lists.proxmox.com>; Thu, 17 Mar 2022 09:20:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 60FD62FC10 for <pve-devel@lists.proxmox.com>; Thu, 17 Mar 2022 09:20:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 39AB846E85 for <pve-devel@lists.proxmox.com>; Thu, 17 Mar 2022 09:20:17 +0100 (CET) Message-ID: <e49d58c6-dc89-3f07-4310-1c4e1e797ef1@proxmox.com> Date: Thu, 17 Mar 2022 09:20:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Fabian Ebner <f.ebner@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com>, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= <f.gruenbichler@proxmox.com> References: <20211216121233.162288-1-f.ebner@proxmox.com> <20211216121233.162288-10-f.ebner@proxmox.com> <3c52b1a7-c53f-27de-f072-f8ddab32e102@proxmox.com> <3fc10567-ee00-5c5c-3879-131327d1a5ab@proxmox.com> <dbd1e289-0ed0-02a7-53c7-c6de6550750a@proxmox.com> <70e4e8d7-848d-0f1c-e03e-07247afbd0e2@proxmox.com> <49888786-d3d2-c938-815a-613fdcec70e0@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <49888786-d3d2-c938-815a-613fdcec70e0@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH guest-common 1/1] vzdump: schema: add 'notes' and 'protected' properties X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 17 Mar 2022 08:20:47 -0000 On 17.03.22 09:18, Fabian Ebner wrote: >> Agree. So, to summarize, vzdump does the interpreting for a plain, new `--notes` >> CLI which it also prints (with variables already resolved) in the task log and >> sets that also as note for the (created) backup. >> >> The job config would get a new notes-template config that allows to add such >> a dynamically interpreted string to each backup created by this job by bassing >> it as --notes to vzdump. That way we avoid vzdump having two different, clashing, >> CLI options but keep it cleanly separated for the job definitions. > > I think it'd be better or even necessary for vzdump to do the variable > expansion, because some things are not known when we start the job, for > example guest name. It'd then be enough to add a notes-template option > for vzdump, and have the job pass it along as-is with the rest of the > vzdump-config. I meant to convey that, the "with variables already resolved" was meant for when printed to the task log, not when passed to vzdump (worded a bit confusing though) ;-)