From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 2C6831FF16F
	for <inbox@lore.proxmox.com>; Thu, 13 Feb 2025 14:52:55 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 33ADB5CBA;
	Thu, 13 Feb 2025 14:52:52 +0100 (CET)
Message-ID: <e3f72e3f-c892-4b81-b7d3-8a27a5839842@proxmox.com>
Date: Thu, 13 Feb 2025 14:52:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
References: <20250211120541.163621-1-l.wagner@proxmox.com>
 <20250211120541.163621-25-l.wagner@proxmox.com>
 <cdlqcqdehmqrrsxfwuj4emgokmdo37d3vhsthibln4ka5xnpy2@tbtjs3omqqvr>
Content-Language: de-AT, en-US
From: Lukas Wagner <l.wagner@proxmox.com>
In-Reply-To: <cdlqcqdehmqrrsxfwuj4emgokmdo37d3vhsthibln4ka5xnpy2@tbtjs3omqqvr>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.010 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager 24/25]
 pdm-client: add metric collection API methods
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>

On  2025-02-13 13:10, Wolfgang Bumiller wrote:
>> +    /// Trigger metric collection for a single remote or all, if no remote is provided.
>> +    pub async fn trigger_metric_collection(
>> +        &self,
>> +        remote: Option<&str>,
>> +    ) -> Result<(), proxmox_client::Error> {
>> +        let path = "/api2/extjs/metric-collection/trigger";
>> +
>> +        #[derive(Serialize)]
>> +        struct TriggerParams<'a> {
>> +            #[serde(skip_serializing_if = "Option::is_none")]
>> +            remote: Option<&'a str>,
>> +        }
>> +
>> +        self.0
>> +            .post(path, &TriggerParams { remote })
>> +            .await?
>> +            .expect_json::<()>()?;
> 
> Look like this should be `.nodata()`?
> 

Thx, fixed for v2.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel