From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 618B7734D8 for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 10:39:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5855116ECD for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 10:39:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E3ADC16EBF for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 10:39:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BB31144668 for <pve-devel@lists.proxmox.com>; Thu, 7 Oct 2021 10:39:58 +0200 (CEST) Message-ID: <e2a6d69f-0580-f36c-934f-c287fbbee7a2@proxmox.com> Date: Thu, 7 Oct 2021 10:38:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20211007082727.1385888-1-d.csapak@proxmox.com> <20211007082727.1385888-4-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20211007082727.1385888-4-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.214 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager 2/7] postinst: use reload-or-restart instead of reload-or-try-restart X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 07 Oct 2021 08:39:59 -0000 we normally use `d/<foo>` for changes to the debian/ folder, iow, packaging changes. On 07.10.21 10:27, Dominik Csapak wrote: > the only difference is that reload-or-try-restart does not > do anything if the service is not started already. > > on upgrade, we explicitely check if the service is enabled, and only s/explicitely/explicitly/ > then do this action. so it would now start daemons that were > stopped but not disabled (which is not really valid state anyway) > > this starts new daemons (like the pvescheduler) automatically on > a package upgrade > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > debian/postinst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > with a few brushups to the commit message (and I took the freedom to add a suggested-by me ;): applied, thanks!