From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <m.heiserer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id AA9917159D
for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 16:40:01 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 9A62EA4AD
for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 16:39:31 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 65312A4A0
for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 16:39:30 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 32C9F43230
for <pve-devel@lists.proxmox.com>; Wed, 8 Jun 2022 16:39:30 +0200 (CEST)
Message-ID: <e1a61550-8621-f620-7631-a61d0a797f8f@proxmox.com>
Date: Wed, 8 Jun 2022 16:39:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
Thunderbird/91.9.0
Content-Language: en-US
To: pve-devel@lists.proxmox.com
References: <20220608115428.250668-1-daniel@bowdernet.com>
<20220608115428.250668-6-daniel@bowdernet.com>
From: Matthias Heiserer <m.heiserer@proxmox.com>
In-Reply-To: <20220608115428.250668-6-daniel@bowdernet.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.692 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -1.732 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH 5/5] fix #3593: Added vm core pinning
pve-manager
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2022 14:40:01 -0000
On 08.06.2022 13:54, Daniel Bowder wrote:
> Signed-off-by: Daniel Bowder <daniel@bowdernet.com>
> ---
> The fifth patch adds the cpuset value to the GUI under the VM.Config.Options panel. The cpuset is set as a vtype of CPUSet so that it can be checked by the regex match in the fouth patch. This was modeled after the existing 'name' option,
typo: fouth -> fourth
Don't think you should be referencing other patches by number in the
commit message though, so the comment is a fitting location for this remark.
where the labels and textfield type have been changed.
> www/manager6/qemu/Options.js | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
> index a1def4bb..ce356130 100644
> --- a/www/manager6/qemu/Options.js
> +++ b/www/manager6/qemu/Options.js
> @@ -341,6 +341,36 @@ Ext.define('PVE.qemu.Options', {
> hookscript: {
> header: gettext('Hookscript'),
> },
> + cpuset: {
> + required: false,
> + header: gettext('CPU Set'),
> + defaultValue: "",
> + editor: caps.vms['VM.Config.Options'] ? {
> + xtype: 'proxmoxWindowEdit',
> + subject: gettext('CPU Set'),
> + items: {
> + xtype: 'inputpanel',
> + items: {
> + xtype: 'textfield',
> + name: 'cpuset',
> + vtype: 'CPUSet',
> + value: '',
> + fieldLabel: gettext('cpuset'),
> + allowBlank: true,
> + emptyText: gettext("Pin to cores (e.g. 0,2-6,8)"),
> + },
> + onGetValues: function(values) {
> + var params = values;
> + if (values.cpuset === undefined ||
> + values.cpuset === null ||
> + values.cpuset === '') {
> + params = { 'delete': 'cpuset' };
> + }
> + return params;
> + },
> + },
> + } : undefined,
> + },
> };
>
> var baseurl = 'nodes/' + nodename + '/qemu/' + vmid + '/config';
Is a string the best way of entering the CPUs in the GUI? Maybe a
dropdown where you can (un)select the cores?