From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 3/4] ui: pci map edit: improve new host mappings dialog
Date: Tue, 20 Jun 2023 14:34:19 +0200 [thread overview]
Message-ID: <e16fcddf-de59-2a64-0f02-ed4bcf0b64b2@proxmox.com> (raw)
In-Reply-To: <20230619141307.119430-3-d.csapak@proxmox.com>
Am 19.06.23 um 16:13 schrieb Dominik Csapak:
> by disallowing nodes to be selected where a mapping already exists
> and not preselecting a node
>
Two UX nits, not sure how hard they would be to address:
- if all nodes already have a mapping, disable the button (or after the
RFC, hide the action element)
- maybe pre-select the first valid node that has no mapping yet instead
of none?
next prev parent reply other threads:[~2023-06-20 12:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 14:13 [pve-devel] [PATCH manager 1/4] ui: resource map tree: make 'ok' status clearer Dominik Csapak
2023-06-19 14:13 ` [pve-devel] [PATCH manager 2/4] ui: pci map edit: reintroduce warnings checks Dominik Csapak
2023-06-20 12:16 ` Fiona Ebner
2023-06-19 14:13 ` [pve-devel] [PATCH manager 3/4] ui: pci map edit: improve new host mappings dialog Dominik Csapak
2023-06-20 12:34 ` Fiona Ebner [this message]
2023-06-19 14:13 ` [pve-devel] [RFC PATCH manager 4/4] ui: pci mapping: rework mapping panel for better user experience Dominik Csapak
2023-06-20 9:35 ` Aaron Lauterer
2023-06-20 9:57 ` Dominik Csapak
2023-06-20 10:18 ` Aaron Lauterer
2023-06-20 10:48 ` Dominik Csapak
2023-06-20 13:25 ` Fiona Ebner
2023-06-20 14:13 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e16fcddf-de59-2a64-0f02-ed4bcf0b64b2@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal