From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B1BDD1FF165 for ; Thu, 14 Aug 2025 17:10:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C893016D84; Thu, 14 Aug 2025 17:12:27 +0200 (CEST) Message-ID: Date: Thu, 14 Aug 2025 17:11:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion References: Content-Language: en-US From: Fiona Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755184280625 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] Handling 'path' requests during VM deletion X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Hi Andrei, Am 07.08.25 um 11:39 PM schrieb Andrei Perapiolkin via pve-devel: > Hi, > > VM deletion retries 'path'/'free_image' for already-removed volumes; expected plugin behavior on missing volumes is unclear. > > When deleting a VM with multiple attached volumes, Proxmox deletes volumes sequentially (one at a time) and > updates the VM record only after all deletions complete. Could you please file a bug for this: https://bugzilla.proxmox.com ? > If a volume deletion fails mid-process (e.g., network error), the VM record is not updated even though some volumes may have been successfully removed. > A subsequent delete attempt repeats all operations, including 'path' (and 'free_image') calls for volumes that were already deleted. > > > What is the proper response to 'path' and 'free_image' calls for a volume that no longer exists? > For path, should the call fail (e.g., 'die'), succeed with an empty string, or return a 'storage path'? (Most) implementations of path() for plugins shipped by us [0] do not do any I/O at all and thus don't check if the image actually exist. So you can return the path, even if the volume does not exist. Some of our implementations of free_image() fail if the volume does not exist, some do not. Nothing should break if you indicate success when free_image() is called and the image does not exist. [0]: https://git.proxmox.com/?p=pve-storage.git;a=tree;f=src/PVE/Storage;h=26012be26cb3c24515e99a02e7ad438f29c81646;hb=HEAD Best Regards, Fiona _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel