From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 83DD91FF184 for ; Thu, 4 Dec 2025 21:01:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 52177833F; Thu, 4 Dec 2025 21:01:50 +0100 (CET) Message-ID: Date: Thu, 4 Dec 2025 21:01:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox Datacenter Manager development discussion , Dominik Csapak References: <20251204142451.2992215-1-d.csapak@proxmox.com> <20251204142451.2992215-6-d.csapak@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251204142451.2992215-6-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764878459329 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [RFC PATCH datacenter-manager 5/5] ui: main menu: use different icon for pbs remotes X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" Am 04.12.25 um 15:24 schrieb Dominik Csapak: > In most of the UI, we use 'server' for remotes, 'building' for PVE nodes > and 'building-o' for PBS nodes. > > In the main menu we don't have the information if a remote is a single > node or not for PVE, but we know if it's PBS. So show the 'building-o' > for PBS remotes. > > This makes it possible to see which kind of remote it is before > clicking, and wihtout inventing a custom naming scheme. > > Signed-off-by: Dominik Csapak > --- > We can of course choose different icons here if wanted, e.g. 'floppy-o' > for pbs remotes? We should stay consistent though, so this would have to change everywhere, and I'm not so sure if just a floppy-o it's own is great UX. And (lacking) consistency is actually my main gripe with this patch, as we use "fa-server" for remotes in general, but now we do use a remote-type specific icon for PBS but the generic one for PVE. Maybe we should choose another way to differentiate this than the icon, at least until we really got (marketing blessed) product icons (don't hold your breadth for that). One not-so-thought-out idea might be to show the tree letter abbreviation aligned to the right of the icon+label menu entry and styled such that it's rather subtle, like a shallow engraving. One would need to try to see if it looks OK, but that would at least be much more obvious than just some different (still relatively generic) icons. > > Maybe the best option would be to create some custom product icons that > we could use here and maybe for the favicon, etc. ? > > ui/src/main_menu.rs | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/ui/src/main_menu.rs b/ui/src/main_menu.rs > index 18988eaf..8d44d8f1 100644 > --- a/ui/src/main_menu.rs > +++ b/ui/src/main_menu.rs > @@ -347,7 +347,10 @@ impl Component for PdmMainMenu { > &mut content, > &remote.id, > &format!("remote-{}", remote.id), > - Some("fa fa-server"), > + match remote.ty { > + RemoteType::Pve => Some("fa fa-fw fa-server"), > + RemoteType::Pbs => Some("fa fa-fw fa-building-o"), > + }, > { > let remote = remote.clone(); > move |_| match remote.ty { _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel