From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F32D11FF136 for ; Mon, 09 Feb 2026 17:18:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 28CF3CBCD; Mon, 9 Feb 2026 17:19:23 +0100 (CET) Message-ID: Date: Mon, 9 Feb 2026 17:18:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH container] networkedit: fix #4911: changed primaryfield to proxmoxtextfield to allow empty bond-primary To: Lukas Sichert , pve-devel@lists.proxmox.com References: <20260209154916.54446-1-l.sichert@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20260209154916.54446-1-l.sichert@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770653845081 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GCYK47HEGJPVXWNA6NZVDZ7B2QO6Z7VV X-Message-ID-Hash: GCYK47HEGJPVXWNA6NZVDZ7B2QO6Z7VV X-MailFrom: f.weber@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the patch (I run into this regularly myself...)! Some comments on the subject: - if I'm not mistaken it's a bit too long [1] - the repo should be "manager", should "container" - I'd split networkedit into two words: "network edit" - I'd suggest to have "ui:" for frontend changes somewhere (pve-manager also contains backend code) - And "fix #4911:" should be moved to the beginning [1] And on the commit message: In general, the line-length should be at most 72 characters [1]. On 09/02/2026 16:48, Lukas Sichert wrote: > Currently, when creating an active-backup bond, it is not possible to leave the primary-bond field blank, even though this value is optional in the backend. > If no value is currently set in the frontend, it sends the value '' to the backend. There, it is interpreted as the name of an interface, which is incorrect, and therefore the error 'bond-primary: invalid format - invalid network interface name '' ' is displayed. > Changing the field type to 'proxmoxtextfield' will prevent the empty string from being sent due to the way we submit the data [...] If possible, "we" should be avoided in comment messages [1]. Also, it might be nice to be a bit more precise in which sense proxmoxtextfield sends the data differently. > Addtionally, the deleteEmpty flag is set, so that devices, that were unset, will be deleted by the backend. typo: Additionally > > Signed-off-by: Lukas Sichert > --- > src/node/NetworkEdit.js | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js > index 39c7e35..c945139 100644 > --- a/src/node/NetworkEdit.js > +++ b/src/node/NetworkEdit.js > @@ -239,10 +239,11 @@ Ext.define('Proxmox.node.NetworkEdit', { > disabled: true, > }); > > - let primaryfield = Ext.createWidget('textfield', { > + let primaryfield = Ext.createWidget('proxmoxtextfield', { > fieldLabel: 'bond-primary', > name: 'bond-primary', > value: '', > + deleteEmpty: !me.isCreate, > disabled: true, > }); > [1] https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages