From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DAA7A1FF187 for ; Mon, 25 Aug 2025 11:35:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5F1D6DEF5; Mon, 25 Aug 2025 11:35:48 +0200 (CEST) Date: Mon, 25 Aug 2025 11:35:44 +0200 From: Wolfgang Bumiller To: Christian Ebner Message-ID: References: <20250821120435.334573-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250821120435.334573-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756114540995 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox] s3-client: properly uri encode request query parameters X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" applied, thanks On Thu, Aug 21, 2025 at 02:04:35PM +0200, Christian Ebner wrote: > Slashes in object keys as part of the url must not be uri encoded. > They should however be for the query parameters. > > Fix this by correctly setting the flag signaling the > aws_sign_v4_uri_encode helper that this is not to be encoded as > object key. > > Signed-off-by: Christian Ebner > --- > Noticed in the ceph RGW debug log output while checking an unrelated > issue. > > proxmox-s3-client/src/client.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs > index 3bc2a672..7a3fb89a 100644 > --- a/proxmox-s3-client/src/client.rs > +++ b/proxmox-s3-client/src/client.rs > @@ -698,10 +698,10 @@ impl S3Client { > // No further input validation as http::uri::Builder will check path and query > let mut query_iter = query.iter().peekable(); > while let Some((key, value)) = query_iter.next() { > - let key = aws_sign_v4_uri_encode(key, true); > + let key = aws_sign_v4_uri_encode(key, false); > path_and_query.push_str(&key); > if !value.is_empty() { > - let value = aws_sign_v4_uri_encode(value, true); > + let value = aws_sign_v4_uri_encode(value, false); > path_and_query.push('='); > path_and_query.push_str(&value); > } > -- > 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel