From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E40AE62C4E; Tue, 24 Nov 2020 14:12:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D0952CA45; Tue, 24 Nov 2020 14:11:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 70C7FCA38; Tue, 24 Nov 2020 14:11:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3839D404F5; Tue, 24 Nov 2020 14:11:53 +0100 (CET) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>, pbs-devel@lists.proxmox.com References: <20201124090936.21810-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <dffc631b-c509-196e-b5f1-a440454b035d@proxmox.com> Date: Tue, 24 Nov 2020 14:11:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201124090936.21810-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.082 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-partially: [PATCH proxmox-backup/pve-storage/pve-manager v2] show/edit backup comments X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 24 Nov 2020 13:12:23 -0000 On 24.11.20 10:09, Dominik Csapak wrote: > implement editing/showing notes from pve side > for directory and pbs storages > > this series technically consists of a breaking api change > (comments -> notes) in content listing, but since we only just built > packages with the relevant commits, this should be ok... > > i also omitted the suggested 'snapshot list' part of proxmox-backup > but will look into implementing an invisible alias for the clicommand > in rust soon > > changes from v1: > * rename all occurences of 'comment' to 'notes' where possible > (everywhere except the snapshots api of pbs) > * split patches so that pbs ones could be applied later > > ui: enable notesedit for pbs applied all but above, thanks! Please remind me to apply that one, once we bumped PBS again. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E40AE62C4E; Tue, 24 Nov 2020 14:12:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D0952CA45; Tue, 24 Nov 2020 14:11:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 70C7FCA38; Tue, 24 Nov 2020 14:11:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3839D404F5; Tue, 24 Nov 2020 14:11:53 +0100 (CET) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com>, pbs-devel@lists.proxmox.com References: <20201124090936.21810-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <dffc631b-c509-196e-b5f1-a440454b035d@proxmox.com> Date: Tue, 24 Nov 2020 14:11:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201124090936.21810-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.082 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-partially: [pve-devel] [PATCH proxmox-backup/pve-storage/pve-manager v2] show/edit backup comments X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 24 Nov 2020 13:12:23 -0000 On 24.11.20 10:09, Dominik Csapak wrote: > implement editing/showing notes from pve side > for directory and pbs storages > > this series technically consists of a breaking api change > (comments -> notes) in content listing, but since we only just built > packages with the relevant commits, this should be ok... > > i also omitted the suggested 'snapshot list' part of proxmox-backup > but will look into implementing an invisible alias for the clicommand > in rust soon > > changes from v1: > * rename all occurences of 'comment' to 'notes' where possible > (everywhere except the snapshots api of pbs) > * split patches so that pbs ones could be applied later > > ui: enable notesedit for pbs applied all but above, thanks! Please remind me to apply that one, once we bumped PBS again.