From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6F39A729B7 for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 10:58:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C0BAE252 for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 10:57:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E2756E244 for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 10:57:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B17D645A88 for <pve-devel@lists.proxmox.com>; Wed, 26 May 2021 10:57:50 +0200 (CEST) To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20210311102650.6730-1-f.ebner@proxmox.com> <20210311102650.6730-3-f.ebner@proxmox.com> <9435e2d8-021e-06b4-aeee-cf828ce4dd92@proxmox.com> From: Fabian Ebner <f.ebner@proxmox.com> Message-ID: <dfb4f84a-169b-79c1-8cae-0a8cfe9bdb28@proxmox.com> Date: Wed, 26 May 2021 10:57:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <9435e2d8-021e-06b4-aeee-cf828ce4dd92@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 qemu-server 2/5] vmstatus: make template property optional X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 26 May 2021 08:58:21 -0000 Am 15.03.21 um 14:00 schrieb Thomas Lamprecht: > On 11.03.21 11:26, Fabian Ebner wrote: >> to avoid printing 'template: ' with 'qm status <id> --verbose' if it's false. >> >> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com> >> --- >> >> Breaks pve-manager without the previous patch! (e.g. guest's Start/Shutdown >> buttons won't be updated anymore) >> > > we need to hold that one off for a 7.x release, ideally 7.0 > Ping for this one and patch #3 from the same series, now that the versions are bumped. >> Changes from v1: >> * make property optional >> >> PVE/QemuServer.pm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm >> index 1410ecb..8326e66 100644 >> --- a/PVE/QemuServer.pm >> +++ b/PVE/QemuServer.pm >> @@ -2633,7 +2633,7 @@ sub vmstatus { >> $d->{diskread} = 0; >> $d->{diskwrite} = 0; >> >> - $d->{template} = PVE::QemuConfig->is_template($conf); >> + $d->{template} = 1 if PVE::QemuConfig->is_template($conf); >> >> $d->{serial} = 1 if conf_has_serial($conf); >> $d->{lock} = $conf->{lock} if $conf->{lock}; >> >