all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v8 03/10] tools: add bounded join set to run concurrent tasks bound by limit
Date: Wed, 22 Apr 2026 19:32:33 +0200	[thread overview]
Message-ID: <dfb32a11-214c-4cb3-8a9b-02523eadbfbe@proxmox.com> (raw)
In-Reply-To: <20260422131820.769620-4-c.ebner@proxmox.com>

Am 22.04.26 um 15:17 schrieb Christian Ebner:
> The BoundedJoinSet allows to run tasks concurrently via a JoinSet,
> but constrains the number of concurrent tasks by an upper limit.
> 
> In contrast to the ParallelHandler implementation, which is a purely
> sync implementation and does not provide easy handling for returned
> results, this allows to execute tasks in an async context with straight
> forward handling of results, as required for e.g. pulling/pushing of
> backup groups in parallel for sync jobs. Also, log context is easily
> preserved, which is of importance for task logging.
> 
> Co-developed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  pbs-tools/src/bounded_join_set.rs | 81 +++++++++++++++++++++++++++++++
>  pbs-tools/src/lib.rs              |  1 +
>  2 files changed, 82 insertions(+)
>  create mode 100644 pbs-tools/src/bounded_join_set.rs
> 
> diff --git a/pbs-tools/src/bounded_join_set.rs b/pbs-tools/src/bounded_join_set.rs
> new file mode 100644
> index 000000000..07500c66b
> --- /dev/null
> +++ b/pbs-tools/src/bounded_join_set.rs
> @@ -0,0 +1,81 @@
> +//! JoinSet with an upper bound of concurrent tasks.
> +//!
> +//! Allows to run up to the configured number of tasks concurrently in an async
> +//! context.


similar to my reply to the buffered log module: Might be nicer if this lives
in the proxmox rust workspace, and in fact Lukas factored out the
parallel-handler recently into its own crate, depending on the semantic and
dependency overlap this might also go into the newish proxmox-parallel-handler
crate or its own nano crate.

But fine for now to be here, no need for another revision.




  reply	other threads:[~2026-04-22 17:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 13:18 [PATCH proxmox{,-backup} v8 00/10] fix #4182: concurrent group pull/push support for sync jobs Christian Ebner
2026-04-22 13:18 ` [PATCH proxmox v8 01/10] pbs api types: add `worker-threads` to sync job config Christian Ebner
2026-04-22 13:18 ` [PATCH proxmox-backup v8 02/10] tools: implement buffered logger for concurrent log messages Christian Ebner
2026-04-22 17:25   ` Thomas Lamprecht
2026-04-22 13:18 ` [PATCH proxmox-backup v8 03/10] tools: add bounded join set to run concurrent tasks bound by limit Christian Ebner
2026-04-22 17:32   ` Thomas Lamprecht [this message]
2026-04-22 20:19     ` Thomas Lamprecht
2026-04-22 13:18 ` [PATCH proxmox-backup v8 04/10] api: config/sync: add optional `worker-threads` property Christian Ebner
2026-04-22 13:18 ` [PATCH proxmox-backup v8 05/10] fix #4182: server: sync: allow pulling backup groups in parallel Christian Ebner
2026-04-22 13:18 ` [PATCH proxmox-backup v8 06/10] server: pull: prefix log messages and add error context Christian Ebner
2026-04-22 13:18 ` [PATCH proxmox-backup v8 07/10] server: sync: allow pushing groups concurrently Christian Ebner
2026-04-22 13:18 ` [PATCH proxmox-backup v8 08/10] server: push: prefix log messages and add additional logging Christian Ebner
2026-04-22 13:18 ` [PATCH proxmox-backup v8 09/10] sync: move in-progress snapshot filter to helper and use log line sender Christian Ebner
2026-04-22 13:18 ` [PATCH proxmox-backup v8 10/10] ui: expose group worker setting in sync job edit window Christian Ebner
2026-04-22 19:23 ` applied: [PATCH proxmox{,-backup} v8 00/10] fix #4182: concurrent group pull/push support for sync jobs Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfb32a11-214c-4cb3-8a9b-02523eadbfbe@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal