all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Elias Huhsovitz <e.huhsovitz@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager 3/4] fix #6211: ui: vm: options:
Date: Fri, 10 Jul 2026 09:03:49 +0200	[thread overview]
Message-ID: <ded34f74-da5a-4971-b6af-58fdc740ee12@proxmox.com> (raw)
In-Reply-To: <20260708130453.166084-4-e.huhsovitz@proxmox.com>

the commit subject seems to be cut off? (stray newline?)

aside from that:

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 7/8/26 3:05 PM, Elias Huhsovitz wrote:
> The help buttons in the AMD SEV and Intel TDX dialos were pointing to
> the general
> memory documentation.
> Update the links to use the correct documentation anchors
> 
> Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
> ---
>   www/manager6/qemu/SevEdit.js | 2 +-
>   www/manager6/qemu/TdxEdit.js | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/qemu/SevEdit.js b/www/manager6/qemu/SevEdit.js
> index 44db34bd..c308b3ab 100644
> --- a/www/manager6/qemu/SevEdit.js
> +++ b/www/manager6/qemu/SevEdit.js
> @@ -2,7 +2,7 @@ Ext.define('PVE.qemu.SevInputPanel', {
>       extend: 'Proxmox.panel.InputPanel',
>       xtype: 'pveSevInputPanel',
>   
> -    onlineHelp: 'qm_memory', // TODO: change to 'qm_memory_encryption' one available
> +    onlineHelp: 'qm_memory_encryption_sev',
>   
>       viewModel: {
>           data: {
> diff --git a/www/manager6/qemu/TdxEdit.js b/www/manager6/qemu/TdxEdit.js
> index c1f990a9..38948a6c 100644
> --- a/www/manager6/qemu/TdxEdit.js
> +++ b/www/manager6/qemu/TdxEdit.js
> @@ -2,7 +2,7 @@ Ext.define('PVE.qemu.TdxInputPanel', {
>       extend: 'Proxmox.panel.InputPanel',
>       xtype: 'pveTdxInputPanel',
>   
> -    onlineHelp: 'qm_memory', // TODO: change to 'qm_memory_encryption' one available
> +    onlineHelp: 'qm_memory_encryption_tdx',
>   
>       viewModel: {
>           data: {





  reply	other threads:[~2026-07-10  7:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 13:04 [PATCH docs/manager 0/4] manager/docs: fix: #6211: ui: docs: add reference to vm options protection/IDX/SEV Elias Huhsovitz
2026-07-08 13:04 ` [PATCH docs 1/4] qm_memory: update dead links in qm_memory_encryption_sev section on AMD SEV Elias Huhsovitz
2026-07-10  7:02   ` Dominik Csapak
2026-07-08 13:04 ` [PATCH docs 2/4] qm_memory: expand qm_memory_encryption documentation to include Intel TDX Elias Huhsovitz
2026-07-10  7:02   ` Dominik Csapak
2026-07-08 13:04 ` [PATCH manager 3/4] fix #6211: ui: vm: options: Elias Huhsovitz
2026-07-10  7:03   ` Dominik Csapak [this message]
2026-07-08 13:04 ` [PATCH manager 4/4] " Elias Huhsovitz
2026-07-10  7:08   ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ded34f74-da5a-4971-b6af-58fdc740ee12@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal