From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5C7BF1FF17A for ; Fri, 18 Jul 2025 14:45:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 76C261E0FB; Fri, 18 Jul 2025 14:46:57 +0200 (CEST) Message-ID: Date: Fri, 18 Jul 2025 14:46:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Christian Ebner References: <20250715125332.954494-1-c.ebner@proxmox.com> <20250715125332.954494-48-c.ebner@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <20250715125332.954494-48-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1752842781354 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v8 38/45] ui: expose s3 refresh button for datastores backed by object store X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 2025-07-15 14:53, Christian Ebner wrote: > Allows to trigger a refresh of the local datastore contents from > the WebUI. > > Signed-off-by: Christian Ebner > --- > changes since version 7: > - no changes > > www/datastore/Summary.js | 44 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js > index cdb34aea3..d8f59ebc5 100644 > --- a/www/datastore/Summary.js > +++ b/www/datastore/Summary.js > @@ -301,6 +301,31 @@ Ext.define('PBS.DataStoreSummary', { > }); > }, > }, > + { > + xtype: 'button', > + text: gettext('S3 Refresh'), > + hidden: true, > + itemId: 's3RefreshButton', > + reference: 's3RefreshButton', > + handler: function () { > + let me = this; > + let datastore = me.up('panel').datastore; > + Proxmox.Utils.API2Request({ > + url: `/admin/datastore/${datastore}/s3-refresh`, > + method: 'PUT', > + failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus), > + success: function (response, options) { > + Ext.create('Proxmox.window.TaskViewer', { > + upid: response.result.data, > + taskDone: () => { > + me.up('panel').statusStore.load(); > + Ext.ComponentQuery.query('navigationtree')[0]?.reloadStore(); > + }, > + }).show(); > + }, > + }); > + }, > + }, Already discussed off-list: The "S3 Refresh" button should in my opinion be not placed as prominently as it is now. In normal operation, a user should not need it. I'd maybe create some drop-down menu in the "Content" page and use also a bit more text, e.g. "Refresh backup snapshots from S3 bucket" or the like. -- - Lukas _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel