From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 966CF1FF0DF for ; Fri, 28 Aug 2026 12:30:55 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6862A214C6; Fri, 28 Aug 2026 12:30:55 +0200 (CEST) Message-ID: Date: Fri, 28 Aug 2026 12:30:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v2 2/3] fix #6990: server: drop verify state on push job To: Jakob Klocker , pbs-devel@lists.proxmox.com References: <20260821111826.299588-1-j.klocker@proxmox.com> <20260821111826.299588-3-j.klocker@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260821111826.299588-3-j.klocker@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787913041242 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.697 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: R6QCP6QXYF6KWKMDMQ2PJ4INN66Y4VVT X-Message-ID-Hash: R6QCP6QXYF6KWKMDMQ2PJ4INN66Y4VVT X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/21/26 1:18 PM, Jakob Klocker wrote: > When pushing a snapshot the target manifest is recreated from the source > manifest, copying its verify_state. As with pull, this makes the pushed > snapshot appear verified on the remote without its stored copy having > been checked there. > Strip verify_state after copying the unprotected section so the pushed > snapshot is verified independently on the target. > > Link: https://bugzilla.proxmox.com/show_bug.cgi?id=6990 > Signed-off-by: Jakob Klocker > --- Reviewed-by: Christian Ebner