From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id BCD2E8F11
for <pve-devel@lists.proxmox.com>; Wed, 16 Nov 2022 20:11:53 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 9387F23F9F
for <pve-devel@lists.proxmox.com>; Wed, 16 Nov 2022 20:11:23 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 16 Nov 2022 20:11:23 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BD61B44B71
for <pve-devel@lists.proxmox.com>; Wed, 16 Nov 2022 20:11:22 +0100 (CET)
Message-ID: <dd47e35c-d607-782f-f32a-ca12f1e647b8@proxmox.com>
Date: Wed, 16 Nov 2022 20:11:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101
Thunderbird/107.0
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>,
Daniel Tschlatscher <d.tschlatscher@proxmox.com>
References: <20221103153810.690086-1-d.tschlatscher@proxmox.com>
<5fd1a4f0-8afc-ad12-db52-6a19d42ffced@proxmox.com>
Content-Language: en-GB
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <5fd1a4f0-8afc-ad12-db52-6a19d42ffced@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.031 Adjusted
score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9
Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict
=?UTF-8?Q?Alignment=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an
SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [PATCH manager v2 1/2] fix #3719: gui: expose
LXC MTU option in web UI
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 16 Nov 2022 19:11:53 -0000
Am 11/11/2022 um 12:14 schrieb Stefan Hanreich:
> Some=C2=A0Notes:
> - Setting the MTU while the container is running, does not update the M=
TU of
> the running container. If this is intended behavior it might be smart=
to
> document it somewhere or throw a warning. This also doesn't
> work=C2=A0for=C2=A0the=C2=A0VM=C2=A0patch.=C2=A0Not=C2=A0sure=C2=A0if=
=C2=A0this=C2=A0is=C2=A0even=C2=A0possible=C2=A0at=C2=A0runtime=C2=A0tbh.=
> - Adding a network device when the Container is running with a specific=
,
> valid MTU (e.g. 1234) does add the network device to the container, B=
UT it
> has a MTU of 1500. Upon reboot the correct MTU is set. Reloading the
> Network=C2=A0config=C2=A0does=C2=A0not=C2=A0change=C2=A0anything.=C2=A0=
Maybe=C2=A0just=C2=A0an=C2=A0LXC=C2=A0limitation?
>=20
good notes which we should also improve (either implementing it or ensuri=
ng
that the change stays pending if it cannot be hot-plugged), but both
pre-existing behavior and so not a blocker for this.
> Code LGTM - small nit: there is still a gettext('MTU') left in the
> NetworkView,=C2=A0but=C2=A0it=C2=A0has=C2=A0been=C2=A0changed=C2=A0in=C2=
=A0the=C2=A0NetworkInputPanel.
>=20
> Reviewed-by:=C2=A0Stefan=C2=A0Hanreich=C2=A0<s.hanreich@proxmox.com>
> Tested-by:=C2=A0Stefan=C2=A0Hanreich=C2=A0<s.hanreich@proxmox.com>
with above applied, thanks!