From: Christian Ebner <c.ebner@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup 0/2] fixes #7465: add gc-on-unmount flag
Date: Fri, 17 Apr 2026 16:56:20 +0200 [thread overview]
Message-ID: <dcfd04b0-4d43-4d89-b4a7-bffad8f03b33@proxmox.com> (raw)
In-Reply-To: <20260417112755.136134-1-h.laimer@proxmox.com>
On 4/17/26 1:26 PM, Hannes Laimer wrote:
> So GC can run before unmount, without this its somewhat complicated to
> run gc on a datastore that is configured to auto unmount after jobs
> finish.
>
>
> Hannes Laimer (2):
> api: datastore: add option to run garbage collection before unmount
> ui: datastore: expose gc-on-unmount setting
>
> src/api2/admin/datastore.rs | 33 +++++++++++++++++++++++++++------
> src/api2/config/datastore.rs | 9 +++++++++
> www/datastore/OptionView.js | 23 +++++++++++++++++++++++
> 3 files changed, 59 insertions(+), 6 deletions(-)
>
Looks good apart from a few smaller comments and questions.
I'm missing the patch for pbs-api-types though? (Adapted myself for
review since it is a trivial adaption).
prev parent reply other threads:[~2026-04-17 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 11:27 Hannes Laimer
2026-04-17 11:27 ` [PATCH proxmox-backup 1/2] api: datastore: add option to run garbage collection before unmount Hannes Laimer
2026-04-17 14:35 ` Christian Ebner
2026-04-17 11:27 ` [PATCH proxmox-backup 2/2] ui: datastore: expose gc-on-unmount setting Hannes Laimer
2026-04-17 14:56 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcfd04b0-4d43-4d89-b4a7-bffad8f03b33@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.