From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0773068A4F for <pve-devel@lists.proxmox.com>; Thu, 10 Mar 2022 08:47:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EC025787E for <pve-devel@lists.proxmox.com>; Thu, 10 Mar 2022 08:46:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5B3D87873 for <pve-devel@lists.proxmox.com>; Thu, 10 Mar 2022 08:46:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2490141DD3 for <pve-devel@lists.proxmox.com>; Thu, 10 Mar 2022 08:46:57 +0100 (CET) Message-ID: <dc29a3a9-9635-db51-d0c9-90739738e8ed@proxmox.com> Date: Thu, 10 Mar 2022 08:46:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20211216121233.162288-1-f.ebner@proxmox.com> From: Fabian Ebner <f.ebner@proxmox.com> In-Reply-To: <20211216121233.162288-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.128 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nfsplugin.pm, glusterfsplugin.pm, common.pm, plugin.pm, dirplugin.pm, storage.pm, pbsplugin.pm, btrfsplugin.pm, cifsplugin.pm, cephfsplugin.pm, vzdump.pm] URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence Subject: Re: [pve-devel] [PATCH-SERIES storage/manager/guest-common/docs] improvements for protected backups X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 10 Mar 2022 07:47:28 -0000 Ping for the series. Or do we not want the limit after all (as far as I'm aware, nobody complained yet)? Am 16.12.21 um 13:12 schrieb Fabian Ebner: > The series consists of two parts: > > First part (up to docs 2/2) is for introducing a storage property > to limit the number of protected backups and only count unprotected > backups for the limit check in vzdump. > > Second part is a convenience feature allowing 'protected' and 'notes' > to be set directly with vzdump and for manual backups in the UI. > > > storage: > > Fabian Ebner (2): > list volumes: also return backup type for backups > plugins: allow limiting the number of protected backups per guest > > PVE/Storage.pm | 24 ++++++++++++++++++++++++ > PVE/Storage/BTRFSPlugin.pm | 3 ++- > PVE/Storage/CIFSPlugin.pm | 1 + > PVE/Storage/CephFSPlugin.pm | 1 + > PVE/Storage/DirPlugin.pm | 1 + > PVE/Storage/GlusterfsPlugin.pm | 1 + > PVE/Storage/NFSPlugin.pm | 1 + > PVE/Storage/PBSPlugin.pm | 2 ++ > PVE/Storage/Plugin.pm | 8 ++++++++ > test/list_volumes_test.pm | 10 ++++++++++ > 10 files changed, 51 insertions(+), 1 deletion(-) > > > manager: > > Fabian Ebner (6): > vzdump: backup file list: drop unused parameter > vzdump: backup limit: only count unprotected backups > ui: storage edit: retention: add max-protected-backups setting > ui: storage creation: retention: dynamically adapt > max-protected-backups > vzdump: support setting protected status and notes > ui: backup: allow setting protected and notes for manual backup > > PVE/VZDump.pm | 69 ++++++++++++++++++--------- > www/manager6/panel/BackupJobPrune.js | 71 ++++++++++++++++++++++++---- > www/manager6/storage/Base.js | 1 + > www/manager6/window/Backup.js | 25 +++++++++- > 4 files changed, 132 insertions(+), 34 deletions(-) > > > guest-common: > > Fabian Ebner (1): > vzdump: schema: add 'notes' and 'protected' properties > > src/PVE/VZDump/Common.pm | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > > docs: > > Fabian Ebner (2): > storage: switch to prune-backups in examples > vzdump/storage: mention protected backups limit and give an example > > pve-storage-dir.adoc | 9 +++++---- > pve-storage-pbs.adoc | 2 +- > vzdump.adoc | 3 +++ > 3 files changed, 9 insertions(+), 5 deletions(-) >