From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 57D261FF150 for ; Mon, 06 Jul 2026 14:29:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 27AAD2144C; Mon, 06 Jul 2026 14:29:08 +0200 (CEST) Message-ID: Date: Mon, 6 Jul 2026 14:29:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Robert Obkircher Subject: Re: [PATCH proxmox-backup v3 14/15] tape: use proxmox-product-config to generate create options To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260701140412.200920-1-c.ebner@proxmox.com> <20260701140412.200920-15-c.ebner@proxmox.com> Content-Language: en-US, de-AT In-Reply-To: <20260701140412.200920-15-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783340937797 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HRSE2VJFZVWWNLXQLM6O66MYFTOLAA6P X-Message-ID-Hash: HRSE2VJFZVWWNLXQLM6O66MYFTOLAA6P X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 01.07.26 16:05, Christian Ebner wrote: > Instead of redefining them, use the global helper defined in > proxmox-product-config. Requires the crates init function to be > called exactly once before using in any callpath. > > Signed-off-by: Christian Ebner > --- > src/tape/inventory.rs | 6 +----- > src/tape/media_catalog_cache.rs | 10 +--------- > 2 files changed, 2 insertions(+), 14 deletions(-) > > diff --git a/src/tape/inventory.rs b/src/tape/inventory.rs > index 6c54738fb..12cca02c6 100644 > --- a/src/tape/inventory.rs > +++ b/src/tape/inventory.rs > @@ -177,11 +177,7 @@ impl Inventory { > // We cannot use chown inside test environment (no permissions) > CreateOptions::new().perm(mode) > } else { > - let backup_user = pbs_config::backup_user()?; > - CreateOptions::new() > - .perm(mode) > - .owner(backup_user.uid) > - .group(backup_user.gid) > + proxmox_product_config::default_create_options() > }; I think the then branch of this if statement could be removed, because for cfg!(test) the backup_user is already set to the current user. > [..]