From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9CB3F74393 for <pve-devel@lists.proxmox.com>; Mon, 21 Jun 2021 11:19:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9087C1A46F for <pve-devel@lists.proxmox.com>; Mon, 21 Jun 2021 11:19:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2D4891A461 for <pve-devel@lists.proxmox.com>; Mon, 21 Jun 2021 11:19:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0855F40C0C for <pve-devel@lists.proxmox.com>; Mon, 21 Jun 2021 11:19:08 +0200 (CEST) Message-ID: <da5fca13-0fb2-16c7-0b48-11a269707a3c@proxmox.com> Date: Mon, 21 Jun 2021 11:18:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com> References: <20210618105938.57107-1-f.ebner@proxmox.com> <20210618105938.57107-6-f.ebner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210618105938.57107-6-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.724 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server 2/2] migrate: enforce that image content type is available X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 21 Jun 2021 09:19:08 -0000 On 18.06.21 12:59, Fabian Ebner wrote: > and use it for the vdisk_list call too. This avoids scanning (and picking up > volumes from!) storages that are not even configured to hold images. > > Previously, the content type was only enforced when a storage map was present. > > Also serves a bit as a preparation to enforce content type on guest startup, > because now migration failure happens early and not only when trying to start > the guest on the remote node. > > Signed-off-by: Fabian Ebner <f.ebner@proxmox.com> > --- > PVE/QemuMigrate.pm | 25 ++++++++++++++++--------- > PVE/QemuServer.pm | 3 +++ > 2 files changed, 19 insertions(+), 9 deletions(-) > > applied, thanks!