From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 94F851FF15E
	for <inbox@lore.proxmox.com>; Mon, 10 Nov 2025 09:55:53 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id CADD41010A;
	Mon, 10 Nov 2025 09:56:38 +0100 (CET)
Message-ID: <d982d258-1aea-48ea-92ea-4e83274b3a85@proxmox.com>
Date: Mon, 10 Nov 2025 09:56:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Hannes Laimer <h.laimer@proxmox.com>
References: <20251107132329.42965-1-h.laimer@proxmox.com>
 <20251107132329.42965-5-h.laimer@proxmox.com>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <20251107132329.42965-5-h.laimer@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1762764943608
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.048 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 1/3] api: taffic-control:
 update/delete users on rule correctly
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pbs-devel-bounces@lists.proxmox.com
Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com>


Reviewed-by: Christian Ebner <c.ebner@proxmox.com>

On 11/7/25 2:23 PM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>   src/api2/config/traffic_control.rs | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/src/api2/config/traffic_control.rs b/src/api2/config/traffic_control.rs
> index e02aa20a..49b1267e 100644
> --- a/src/api2/config/traffic_control.rs
> +++ b/src/api2/config/traffic_control.rs
> @@ -116,6 +116,8 @@ pub enum DeletableProperty {
>       Comment,
>       /// Delete the timeframe property
>       Timeframe,
> +    /// Delete the users property
> +    Users,
>   }
>   
>   // fixme: use  TrafficControlUpdater
> @@ -187,6 +189,9 @@ pub fn update_traffic_control(
>                   DeletableProperty::Timeframe => {
>                       data.timeframe = None;
>                   }
> +                DeletableProperty::Users => {
> +                    data.users = None;
> +                }
>               }
>           }
>       }
> @@ -222,6 +227,9 @@ pub fn update_traffic_control(
>       if update.timeframe.is_some() {
>           data.timeframe = update.timeframe;
>       }
> +    if update.users.is_some() {
> +        data.users = update.users;
> +    }
>   
>       config.set_data(&name, "rule", &data)?;
>   



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel