From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8CCCC70958 for <pve-devel@lists.proxmox.com>; Mon, 6 Sep 2021 13:01:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7CDA5FCBA for <pve-devel@lists.proxmox.com>; Mon, 6 Sep 2021 13:00:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0D258FCAB for <pve-devel@lists.proxmox.com>; Mon, 6 Sep 2021 13:00:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C774B445AA for <pve-devel@lists.proxmox.com>; Mon, 6 Sep 2021 13:00:42 +0200 (CEST) Message-ID: <d98135c4-35c3-a3ec-e258-6e04b507fdc3@proxmox.com> Date: Mon, 6 Sep 2021 13:00:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Thunderbird/92.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20210906101908.2155602-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210906101908.2155602-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.307 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] ui: add version to extjs script urls X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 06 Sep 2021 11:01:13 -0000 On 06.09.21 12:19, Dominik Csapak wrote: > so that we circumvent browsers caching 6.0 extjs js/css > > also depend on extjs 7.0.0 in debian control > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > this should (at least for new users upgrading) fix the browser caching > issue for extjs (we had some now in the forums) > > i did it this way since we do not often change version of the extjs > package (since its a big task everytime anyway), but if wanted i can > do it differently. e.g.: > * hardcode it in the perl code > * generate it during the build (also for the control file) > > but imho this is fine for extjs > I put above info with only slight adaptions in the commit message, IMO such reasoning is very valuable information that should be archived in source control. > debian/control | 2 +- > www/index.html.tpl | 14 +++++++------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > applied, thanks!