From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 8550A1FF168
for <inbox@lore.proxmox.com>; Tue, 18 Feb 2025 10:20:00 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 8CB9F79F3;
Tue, 18 Feb 2025 10:19:55 +0100 (CET)
Message-ID: <d9541157-0b66-439f-afb4-de112c6c384b@proxmox.com>
Date: Tue, 18 Feb 2025 10:19:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Markus Frank <m.frank@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
References: <20250217140705.271726-1-philipp.giersfeld@canarybit.eu>
<20250217140705.271726-6-philipp.giersfeld@canarybit.eu>
Content-Language: en-US
In-Reply-To: <20250217140705.271726-6-philipp.giersfeld@canarybit.eu>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.016 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: Re: [pve-devel] [PATCH pve-manager v2 1/1] Add configuration
options for AMD SEV-SNP
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Thank you for your effort to make amd sev snp support possible.
For this patch I have some comments inline below.
For the rest of the patch series, it is still working fine.
If the qemu-server and edk2-firmware patches do not change, you can add this there:
Tested-by: Markus Frank <m.frank@proxmox.com>
On 2025-02-17 15:06, Philipp Giersfeld wrote:
> Expand input panel with AMD SEV-SNP selection, and relevant optional
> parameters similar to existing options for AMD SEV(-ES).
>
> Further, upon selecting AMD SEV-SNP, issue a warning that EFI disks are
> not included when using SEV-SNP.
>
> Signed-off-by: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
> Reviewed-by: Daniel Kral <d.kral at proxmox.com>
> ---
>
> changes since v1: https://lists.proxmox.com/pipermail/pve-devel/2025-February/068159.html
> * Fix formatting and code layout
> * Add note in WebUI for required host kernel version
> * Disable key-sharing option for SNP
>
> Signed-off-by: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
> ---
The two lines above are too much. You do not need another signoff after the comment.
> www/manager6/qemu/Options.js | 1 +
> www/manager6/qemu/SevEdit.js | 44 ++++++++++++++++++++++++++++++++----
> 2 files changed, 41 insertions(+), 4 deletions(-)
>
> diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
> index cbe9e52b..49a921cd 100644
> --- a/www/manager6/qemu/Options.js
> +++ b/www/manager6/qemu/Options.js
> @@ -346,6 +346,7 @@ Ext.define('PVE.qemu.Options', {
> let amd_sev = PVE.Parser.parsePropertyString(value, "type");
> if (amd_sev.type === 'std') return 'AMD SEV (' + value + ')';
> if (amd_sev.type === 'es') return 'AMD SEV-ES (' + value + ')';
> + if (amd_sev.type === 'snp') return 'AMD SEV-SNP (' + value + ')';
> return value;
> },
> },
> diff --git a/www/manager6/qemu/SevEdit.js b/www/manager6/qemu/SevEdit.js
> index a2080f2d..5c14b90a 100644
> --- a/www/manager6/qemu/SevEdit.js
> +++ b/www/manager6/qemu/SevEdit.js
> @@ -9,7 +9,8 @@ Ext.define('PVE.qemu.SevInputPanel', {
> type: '__default__',
> },
> formulas: {
> - sevEnabled: get => get('type') !== '__default__',
> + sevEnabled: get => get('type') === 'std' || get('type') === 'es' || get('type') === 'snp',
> + snpEnabled: get => get('type') === 'snp',
> },
> },
>
> @@ -21,10 +22,14 @@ Ext.define('PVE.qemu.SevInputPanel', {
> if (!values.debug) {
> values["no-debug"] = 1;
> }
> + if (values.smt) {
> + values["allow-smt"] = 1;
> + }
> if (!values["key-sharing"]) {
> values["no-key-sharing"] = 1;
> }
if (!values["key-sharing"] && values.type !== 'snp') {
Otherwise, it sets no-key-sharing, which is not possible with sev-snp.
> delete values.debug;
> + delete values.smt;
> delete values["key-sharing"];
> let ret = {};
> ret['amd-sev'] = PVE.Parser.printPropertyString(values, 'type');
> @@ -36,13 +41,16 @@ Ext.define('PVE.qemu.SevInputPanel', {
> if (PVE.Parser.parseBoolean(values["no-debug"])) {
> values.debug = 0;
> }
> + if (PVE.Parser.parseBoolean(values["allow-smt"])) {
> + values.smt = 1;
> + }
> if (PVE.Parser.parseBoolean(values["no-key-sharing"])) {
> values["key-sharing"] = 0;
> }
> this.callParent(arguments);
> },
>
> - items: {
> + items: [{
> xtype: 'proxmoxKVComboBox',
> fieldLabel: gettext('AMD SEV Type'),
> labelWidth: 150,
> @@ -52,11 +60,28 @@ Ext.define('PVE.qemu.SevInputPanel', {
> ['__default__', Proxmox.Utils.defaultText + ' (' + Proxmox.Utils.disabledText + ')'],
> ['std', 'AMD SEV'],
> ['es', 'AMD SEV-ES (highly experimental)'],
> + ['snp', 'AMD SEV-SNP (highly experimental)'],
> ],
> bind: {
> value: '{type}',
> },
> },
> + {
> + xtype: 'displayfield',
> + userCls: 'pmx-hint',
> + value: gettext('WARNING: When using SEV-SNP no EFI disk is loaded as pflash.'),
> + bind: {
> + hidden: '{!snpEnabled}',
> + },
> + },
> + {
> + xtype: 'displayfield',
> + userCls: 'pmx-hint',
> + value: gettext('Note: SEV-SNP requires host kernel version 6.11 or higher.'),
> + bind: {
> + hidden: '{!snpEnabled}',
> + }
Yes, this is what I meant. Looks good.
Here is just a comma ',' missing after the curly brackets '}' from bind.
> + }],
>
> advancedItems: [
> {
> @@ -77,8 +102,19 @@ Ext.define('PVE.qemu.SevInputPanel', {
> name: 'key-sharing',
> value: 1,
> bind: {
> - hidden: '{!sevEnabled}',
> - disabled: '{!sevEnabled}',
> + hidden: '{!sevEnabled || snpEnabled}',
> + disabled: '{!sevEnabled || snpEnabled}',
> + },
> + },
> + {
> + xtype: 'proxmoxcheckbox',
> + fieldLabel: gettext('Allow SMT'),
> + labelWidth: 150,
> + name: 'smt',
> + value: 1,
> + bind: {
> + hidden: '{!snpEnabled}',
> + disabled: '{!snpEnabled}',
> },
> },
> {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel