Re: [PATCH proxmox-backup v3 21/30] ui: expose assigning encryption key to sync jobs

[Christian Ebner <c.ebner@proxmox.com>]

On 4/15/26 4:47 PM, Michael Köppl wrote:
> On Tue Apr 14, 2026 at 2:59 PM CEST, Christian Ebner wrote:
> 
> [snip]
> 
>> +                column2: [
>> +                    {
>> +                        xtype: 'box',
>> +                        style: {
>> +                            'inline-size': '325px',
>> +                            'overflow-wrap': 'break-word',
>> +                        },
>> +                        padding: '5',
>> +                        html: gettext(
>> +                            'Active encryption key is used to encrypt snapshots which are not encrypted on the source during sync. Already encrypted contents are unaffected, partially encrypted contents skipped if set.',
> 
> @Daniel and I discussed this off-list during testing and both found it
> a bit difficult to understand at first glance what this means. Perhaps
> something like this could improve it, also using active voice:
> 
> "When pushing, the system uses the active encryption key to encrypt
> unencrypted sources snapshots. It leaves existing encrypted content
> as-is, and skips partially encrypted content if the skip setting is
> turned on."
> 
>> +                        ),
>> +                        cbind: {
>> +                            hidden: '{!syncDirectionPush}',
>> +                        },
>> +                    },
>> +                    {
>> +                        xtype: 'box',
>> +                        style: {
>> +                            'inline-size': '325px',
>> +                            'overflow-wrap': 'break-word',
>> +                        },
>> +                        padding: '5',
>> +                        html: gettext(
>> +                            'Associated keys store a reference to keys in order to protect them from removal without prior disassociation. On changing the active encryption key, the previous key is added to the associated keys in order to protect from accidental deletion in case it still is required to decrypt contents.',
> 
> same as above, perhaps something like:
> 
> "To prevent premature removal, associated keys hold a reference to a key
> until you explicitly unlink it. When you change your active encryption
> key, the system automatically associates the old key to protect it from
> accidental deletion, ensuring you can still decrypt older contents."
> 
>> +                        ),
>> +                        cbind: {
>> +                            hidden: '{!syncDirectionPush}',
>> +                        },
>> +                    },
>> +                ],
>> +            },
>>           ],
>>       },
>>   });
> 

Agreed, thanks for the suggestions: will incorporate these!