From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A277B1FF137 for ; Tue, 17 Mar 2026 15:16:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3217DF84E; Tue, 17 Mar 2026 15:16:31 +0100 (CET) Message-ID: Date: Tue, 17 Mar 2026 15:15:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox{,-backup} v2 0/2] fix #7329: network: unkwown iface option error To: Shan Shaji , pbs-devel@lists.proxmox.com References: <20260316152101.207406-1-s.shaji@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260316152101.207406-1-s.shaji@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773756916359 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.006 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7RVDOQZGEBGADQMNJPNLIAWU5NR6PAXI X-Message-ID-Hash: 7RVDOQZGEBGADQMNJPNLIAWU5NR6PAXI X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/16/26 4:21 PM, Shan Shaji wrote: > Using `inet6 auto` resulted in an error message in the web GUI. To fix > the issue, I added the `Auto` config method variant to the `NetworkConfigMethod` enum. > This fixed the error in the web GUI, but when editing the interface through the UI, > the `inet6 (auto)` family was still being removed. > > For example, if I updated only the comment for the interface, the `auto` method was dropped. > > This happened because, when editing the interface without providing > `cidr6` or `gateway6` values, the config method was being replaced > with `Manual` regardless of the current `inet6` method from the existing config. > > Later, when writing the config to interfaces.new file if the config method was > `Manual` and there were no values present inside the `inet6` block, then the > entire stanza was removed. > > To fix this, the `inet6` config method is now set to `Manual` only if the > interface method6 prop does not already have a value. > > changes since v1: Thanks @chris > - added `fixes` trailer. > - fixed typo s/Inorder/In order > - api: fixed inet6 stanza getting dropped. > > #### Testing > - added a new bridge interface from the web UI. > - manually added inet6 (auto) address family to /etc/network/interfaces file for the > bridge interface. > - now from web ui, added a comment for the same interface. > - verified if the block is getting removed. The comment was added and the block > not getting removed. > - Now updated the vmbr0 IPv4/CIDR value. > - verified if the method changed from manual to static. > - updated the vmbr0 IPv6/CIDR value. > - verified if the method changed from auto to static. Great, thanks! Can confirm that this now parses the inet6 auto stanza as expected and also no longer modifies it on unrelated network config changes. FWIW, consider: Reviewed-by: Christian Ebner Tested-by: Christian Ebner