From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 960481FF140
	for <inbox@lore.proxmox.com>; Fri, 27 Mar 2026 01:41:56 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 4AC8E1EF42;
	Fri, 27 Mar 2026 01:42:17 +0100 (CET)
Message-ID: <d6a12b5a-f885-4302-9a68-2f74a5101052@proxmox.com>
Date: Fri, 27 Mar 2026 01:41:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH proxmox-ve-rs v7 06/21] frr: add isis configuration and
 templates
To: Gabriel Goller <g.goller@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260323134934.243110-1-g.goller@proxmox.com>
 <20260323134934.243110-7-g.goller@proxmox.com>
Content-Language: en-US
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20260323134934.243110-7-g.goller@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1774572053617
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -0.009 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: BGDOUTHAF2S3KB427RCT4PPYDZNLV54E
X-Message-ID-Hash: BGDOUTHAF2S3KB427RCT4PPYDZNLV54E
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 23.03.26 um 14:51 schrieb Gabriel Goller:
> +++ b/proxmox-frr-templates/templates/isisd.jinja
> +{% if router_config.redistribute.ipv4_connected %}
> + redistribute ipv4 connected {{ router_config.redistribute.ipv4_connected }}
> +{% endif %}
> +{% if router_config.redistribute.ipv6_connected %}
> + redistribute ipv6 connected {{ router_config.redistribute.ipv6_connected }}
> +{% endif %}

This accesses .ipv4_connected on redistribute without first checking that
redistribute is non-null. With minijinja strict mode (enabled in patch 09/21),
the null.attr evaluates to undefined, which is falsy in {% if %} so it happens
to work, but it's a bit fragile. An outer guard would be cleaner:

  {% if router_config.redistribute %}
  {% if router_config.redistribute.ipv4_connected %}
  ...