From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 432391FF17C for ; Wed, 23 Jul 2025 15:32:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A2E8813416; Wed, 23 Jul 2025 15:34:06 +0200 (CEST) Message-ID: Date: Wed, 23 Jul 2025 15:33:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pve-devel@lists.proxmox.com References: <20250723132116.117742-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20250723132116.117742-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753277602110 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 qemu-server 1/2] drive device: fix regression with missing '/dev/disk/by-id' paths X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 23.07.25 um 3:21 PM schrieb Fiona Ebner: > With the switch to '-blockdev', it is necessary to explicitly specify > the device ID for SCSI drives, see also [0]. Otherwise, the device > paths in '/dev/disk/by-id' would be missing. For IDE/SATA, the paths > are still present with '-blockdev' without additional changes and > VirtIO block did not have such paths even before. The relevant > 'ide-{cd,hd}' and 'virtio-blk-pci' devices do not seem to have an > option that would be equivalent to the 'scsi-{cd,hd}' 'device_id' > option. > > While the change should be backwards-compatible even with '-drive', > guard it with machine version 10.0 just to be sure. > > [0]: https://gitlab.com/libvirt/libvirt/-/commit/a1dce96236f6d35167924fa7e6a70f58f394b23c > > Fixes: aaf48d8e ("command line: switch to blockdev starting with machine version 10.0") > Co-developed-by: Thomas Lamprecht > Signed-off-by: Fiona Ebner > --- > > v2: resend with --transfer-encoding=base64 Seems like the list auto-converts to Content-Transfer-Encoding: 7bit and breaks it again... I created a blockdev-fixups branch in my qemu-server staff repo for this. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel