From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id 29FFF7276C; Tue, 13 Apr 2021 09:24:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 1825627364; Tue, 13 Apr 2021 09:23:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id 7924727355; Tue, 13 Apr 2021 09:23:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 31DE04205F; Tue, 13 Apr 2021 09:23:40 +0200 (CEST) Message-ID: <d5cce679-33a1-1c0c-35ec-c6739a339b07@proxmox.com> Date: Tue, 13 Apr 2021 09:23:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Thomas Lamprecht <t.lamprecht@proxmox.com>, Stefan Reiter <s.reiter@proxmox.com>, pve-devel@lists.proxmox.com References: <20210412153252.22652-1-s.reiter@proxmox.com> <20210412153252.22652-2-s.reiter@proxmox.com> <3e6c8636-f44a-6c23-b782-d567f2446fff@proxmox.com> From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <3e6c8636-f44a-6c23-b782-d567f2446fff@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.165 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, proxmox.com] Subject: Re: [pve-devel] [pbs-devel] applied: [PATCH proxmox-backup 2/2] api/datastore: allow pxar file download of entire archive X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 13 Apr 2021 07:24:12 -0000 On 4/13/21 08:39, Thomas Lamprecht wrote: > On 12.04.21 17:32, Stefan Reiter wrote: >> Treat filepaths like "/root.pxar.didx" without a trailing slash as >> wanting to download the entire archive content instead of erroring. The >> zip-creation code already works fine for this scenario. >> >> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> >> --- >> src/api2/admin/datastore.rs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > > applied, thanks! > > But that API is definitively weird in general... just fyi > > 1. old style API definition, should use the #[api()] macro instead the api macro cannot handle AsyncHttp api calls (yet?), but this is required for the stream > 2. perly "params: Value", yeah, no thanks. a result from above, without api macro no de-structuring of parameters > 3. hard coded return stream type, one should be able to download also a single > file as zip, and we knew that we wanted .tar then too, so not providing an > param for that is weird. we always can add as much, but until now, generating a zip for a single file was not really sensible > 4. accessed via /json/ path but never returns json all api calls need a formatter to call, should we add a new one for download type? > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id 29FFF7276C; Tue, 13 Apr 2021 09:24:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id 1825627364; Tue, 13 Apr 2021 09:23:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id 7924727355; Tue, 13 Apr 2021 09:23:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 31DE04205F; Tue, 13 Apr 2021 09:23:40 +0200 (CEST) Message-ID: <d5cce679-33a1-1c0c-35ec-c6739a339b07@proxmox.com> Date: Tue, 13 Apr 2021 09:23:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Thomas Lamprecht <t.lamprecht@proxmox.com>, Stefan Reiter <s.reiter@proxmox.com>, pve-devel@lists.proxmox.com References: <20210412153252.22652-1-s.reiter@proxmox.com> <20210412153252.22652-2-s.reiter@proxmox.com> <3e6c8636-f44a-6c23-b782-d567f2446fff@proxmox.com> From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <3e6c8636-f44a-6c23-b782-d567f2446fff@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.165 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, proxmox.com] Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup 2/2] api/datastore: allow pxar file download of entire archive X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 13 Apr 2021 07:24:12 -0000 On 4/13/21 08:39, Thomas Lamprecht wrote: > On 12.04.21 17:32, Stefan Reiter wrote: >> Treat filepaths like "/root.pxar.didx" without a trailing slash as >> wanting to download the entire archive content instead of erroring. The >> zip-creation code already works fine for this scenario. >> >> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> >> --- >> src/api2/admin/datastore.rs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > > applied, thanks! > > But that API is definitively weird in general... just fyi > > 1. old style API definition, should use the #[api()] macro instead the api macro cannot handle AsyncHttp api calls (yet?), but this is required for the stream > 2. perly "params: Value", yeah, no thanks. a result from above, without api macro no de-structuring of parameters > 3. hard coded return stream type, one should be able to download also a single > file as zip, and we knew that we wanted .tar then too, so not providing an > param for that is weird. we always can add as much, but until now, generating a zip for a single file was not really sensible > 4. accessed via /json/ path but never returns json all api calls need a formatter to call, should we add a new one for download type? > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel > >