From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D3A591FF09C for ; Mon, 02 Nov 2026 15:12:24 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A577921553; Mon, 02 Nov 2026 15:12:24 +0100 (CET) Message-ID: Date: Mon, 2 Nov 2026 15:12:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-yew-widget-toolkit 5/5] widget: form: combobox: update doc to point to `MultiSelect` To: Nicolas Frey , yew-devel@lists.proxmox.com References: <20261028151517.518742-1-n.frey@proxmox.com> <20261028151517.518742-6-n.frey@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20261028151517.518742-6-n.frey@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793628740049 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.335 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: S76W54DCKCIOPBTXIBUAT4WDT6B6SGO5 X-Message-ID-Hash: S76W54DCKCIOPBTXIBUAT4WDT6B6SGO5 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: i would fold this patch into the previous patch On 10/28/26 4:15 PM, Nicolas Frey wrote: > mention it in the note about missing multi-select support, so users > find it more easily. > > Signed-off-by: Nicolas Frey > --- > src/widget/form/combobox.rs | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/widget/form/combobox.rs b/src/widget/form/combobox.rs > index 7de2906..94f997a 100644 > --- a/src/widget/form/combobox.rs > +++ b/src/widget/form/combobox.rs > @@ -30,8 +30,9 @@ use pwt_macros::{builder, widget}; > /// there is not enough room to display the selected values when the combobox > /// is collapsed. Therefore, we have not implemented the multiselect mode. > /// > -/// Please consider using a flat grid instead. If there are few choices, > -/// a segmented button may also be an option. > +/// If only a few values are expected to be selected at once, consider using > +/// [MultiSelect](super::MultiSelect). Otherwise, please consider using a flat grid > +/// instead. If there are few choices, a segmented button may also be an option. > #[widget(pwt=crate, comp=PwtCombobox, @input)] > #[derive(Clone, PartialEq, Properties)] > #[builder]