From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 57DD5606B7 for <pve-devel@lists.proxmox.com>; Wed, 2 Dec 2020 18:04:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4FD0C1EDA9 for <pve-devel@lists.proxmox.com>; Wed, 2 Dec 2020 18:04:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 410351ED9A for <pve-devel@lists.proxmox.com>; Wed, 2 Dec 2020 18:04:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0CFF8448B3 for <pve-devel@lists.proxmox.com>; Wed, 2 Dec 2020 18:04:41 +0100 (CET) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20201202125631.19336-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <d19648bf-76be-a92b-9201-aa261ff0a9fe@proxmox.com> Date: Wed, 2 Dec 2020 18:04:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <20201202125631.19336-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.075 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] fix #3182 #3183: change backup retention mask logic X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 02 Dec 2020 17:04:42 -0000 On 02.12.20 13:56, Dominik Csapak wrote: > instead of relying on the contentTypeField (which does not need to > exists, e.g. for iscsi), explicitely write it into the panel/icon > mapping and check that > > better would be if we query the backend about storage capabilities, > but such an api call does not exist yet, so this should be ok for now > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > www/manager6/Utils.js | 41 +++++++++++++++++++++++----------- > www/manager6/dc/StorageView.js | 1 + > www/manager6/storage/Base.js | 3 +-- > 3 files changed, 30 insertions(+), 15 deletions(-) > > I gave it some thought to finally start the storage schema/capabilities API endpoint we often talked about, but I did not want to rush it and this is way less complicated for now.. applied, thanks!