From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Oguz Bektas <o.bektas@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager] set https_proxy to http_proxy for querying url metadata
Date: Thu, 25 Nov 2021 15:14:27 +0100 [thread overview]
Message-ID: <d128ce9b-1c98-d41c-0461-cf26bc0e7e5b@proxmox.com> (raw)
In-Reply-To: <YZ+ZpRhLPguofnEt@gaia>
On 25.11.21 15:11, Oguz Bektas wrote:
> On Thu, Nov 25, 2021 at 03:08:24PM +0100, Thomas Lamprecht wrote:
>> On 25.11.21 14:48, Oguz Bektas wrote:
>>> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
>>
>> where is this tag coming from? Did not see it on the list, only the comment
>> that it wasn't working?
>
> yes its fixed now... he did review it, and its only a single line, so i
> thought i'll add it before it gets forgotten along the way ;)
>
yeah no, that's not how it works.
first, one line or hundreds, that does not matter, especially one-liners can be
pretty bad. Secondly, the patch was completely broken, which got mentioned, that's
not akin to a R-b tag at all.. Nothing was there to get forgotten along the way.
prev parent reply other threads:[~2021-11-25 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 13:48 Oguz Bektas
2021-11-25 14:08 ` Thomas Lamprecht
2021-11-25 14:11 ` Oguz Bektas
2021-11-25 14:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d128ce9b-1c98-d41c-0461-cf26bc0e7e5b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal